You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Hadoop QA (Jira)" <ji...@apache.org> on 2020/07/31 20:13:00 UTC

[jira] [Commented] (YARN-8785) Improve the error message when a bind mount is not whitelisted

    [ https://issues.apache.org/jira/browse/YARN-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17169128#comment-17169128 ] 

Hadoop QA commented on YARN-8785:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  8s{color} | {color:red} https://github.com/apache/hadoop/pull/420 does not apply to branch-3.1. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| GITHUB PR | https://github.com/apache/hadoop/pull/420 |
| JIRA Issue | YARN-8785 |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-420/2/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |


This message was automatically generated.



> Improve the error message when a bind mount is not whitelisted
> --------------------------------------------------------------
>
>                 Key: YARN-8785
>                 URL: https://issues.apache.org/jira/browse/YARN-8785
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 3.1.0, 2.9.1, 3.1.1, 3.1.2
>            Reporter: Simon Prewo
>            Assignee: Simon Prewo
>            Priority: Major
>              Labels: Docker
>             Fix For: 3.2.0, 3.1.2
>
>         Attachments: YARN-8785-branch-3.1.002.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> A user recieves the error message _Invalid docker rw mount_ when a container tries to mount a directory which is not configured in property  *docker.allowed.rw-mounts*. 
> {code:java}
> Invalid docker rw mount '/usr/local/hadoop/logs/userlogs/application_1536476159258_0004/container_1536476159258_0004_02_000001:/usr/local/hadoop/logs/userlogs/application_1536476159258_0004/container_1536476159258_0004_02_000001', realpath=/usr/local/hadoop/logs/userlogs/application_1536476159258_0004/container_1536476159258_0004_02_000001{code}
> The error message makes the user think "It is not possible due to a docker issue". My suggestion would be to put there a message like *Configuration of the container executor does not allow mounting directory.*.
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/utils/docker-util.c
> CURRENT:
> {code:java}
>     permitted_rw = check_mount_permitted((const char **) permitted_rw_mounts, mount_src);
>     permitted_ro = check_mount_permitted((const char **) permitted_ro_mounts, mount_src);
>     if (permitted_ro == -1 || permitted_rw == -1) {
>       fprintf(ERRORFILE, "Invalid docker mount '%s', realpath=%s\n", values[i], mount_src);
> ...
> {code}
> NEW:
> {code:java}
>     permitted_rw = check_mount_permitted((const char **) permitted_rw_mounts, mount_src);
>     permitted_ro = check_mount_permitted((const char **) permitted_ro_mounts, mount_src);
>     if (permitted_ro == -1 || permitted_rw == -1) {
>       fprintf(ERRORFILE, "Configuration of the container executor does not allow mounting directory '%s', realpath=%s\n", values[i], mount_src);
> ...
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org