You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/15 17:34:43 UTC
[GitHub] [pulsar] Shoothzj opened a new pull request #13345: Fix typo in functions-work.yaml, add functionWebServiceUrl in yaml
Shoothzj opened a new pull request #13345:
URL: https://github.com/apache/pulsar/pull/13345
### Modifications
Fix typo in functions-work.yaml, add functionWebServiceUrl in yaml
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] `no-need-doc`
trival changes, no need doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #13345: Fix typo in functions-work.yaml, add functionWebServiceUrl in yaml
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #13345:
URL: https://github.com/apache/pulsar/pull/13345#discussion_r770753101
##########
File path: conf/functions_worker.yml
##########
@@ -57,6 +57,7 @@ pulsarServiceUrl: pulsar://localhost:6650
# For TLS:
# webServiceUrl=https://localhost:8443/
pulsarWebServiceUrl: http://localhost:8080
+functionWebServiceUrl: http://localhost:8080
Review comment:
I think this will change the behavior of the following code if `workerHostname` is overridden in this file and the operator is relying on the following conditional to set the `functionWebServiceUrl`. Why do we need to add this to the configuration?
https://github.com/apache/pulsar/blob/64bbbd499736825d60a778718b2e7834163d998b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/PulsarWorkerService.java#L432-L435
https://github.com/apache/pulsar/blob/64bbbd499736825d60a778718b2e7834163d998b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java#L618-L620
https://github.com/apache/pulsar/blob/64bbbd499736825d60a778718b2e7834163d998b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java#L599-L604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13345: Fix typo in functions-work.yaml, add functionWebServiceUrl in yaml
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13345:
URL: https://github.com/apache/pulsar/pull/13345#issuecomment-999183636
>
@lhotari Ok, I will start a thread on mail list, for now I will close this PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj closed pull request #13345: Fix typo in functions-work.yaml, add functionWebServiceUrl in yaml
Posted by GitBox <gi...@apache.org>.
Shoothzj closed pull request #13345:
URL: https://github.com/apache/pulsar/pull/13345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13345: Fix typo in functions-work.yaml, add functionWebServiceUrl in yaml
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13345:
URL: https://github.com/apache/pulsar/pull/13345#issuecomment-995301307
@codelipenghui @lhotari @michaeljmarshall @merlimat @315157973 PTAL, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13345: Fix typo in functions-work.yaml, add functionWebServiceUrl in yaml
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13345:
URL: https://github.com/apache/pulsar/pull/13345#issuecomment-997162317
> @Shoothzj - can you provide a little more context for this change? Explicitly adding a default to the `functions_worker.yml` will change the default behavior. Thanks.
@michaeljmarshall
the field `functionWebServiceUrl` is widely used when people deploy `function-works` and `pulsar-broker` divided.
It is more reasonable for this frequently used configuration parameter to appear in the configuration file.
cc @merlimat @315157973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13345: Fix typo in functions-work.yaml, add functionWebServiceUrl in yaml
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13345:
URL: https://github.com/apache/pulsar/pull/13345#issuecomment-998501286
ping @michaeljmarshall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org