You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "christophd (via GitHub)" <gi...@apache.org> on 2026/06/25 09:43:13 UTC
[PR] CAMEL-23817: Embed test plugin in Camel launcher [camel]
christophd opened a new pull request, #24246:
URL: https://github.com/apache/camel/pull/24246
# Description
- Use Citrus JBang commands directly from launcher instead of spawning a new JBang process
- Update to Citrus 5.0.0-M2 for Jackson 3 support and Camel 4.20+
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [x] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
# Tracking
- [x] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
Fixes CAMEL-23817
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [x] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23817: Embed test plugin in Camel launcher [camel]
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on code in PR #24246:
URL: https://github.com/apache/camel/pull/24246#discussion_r3473838713
##########
dsl/camel-jbang/camel-jbang-plugin-test/src/main/java/org/apache/camel/dsl/jbang/core/commands/test/TestPlugin.java:
##########
@@ -139,50 +163,53 @@ private int executeInitCommand(JBangSupport citrus, List<String> args) {
.formatted(CitrusSettings.getApplicationPropertiesFile(), citrusApplicationProperties));
}
}
+ }
- return execute(citrus, "init", args);
+ /**
+ * Evaluate the current runtime Camel JBang or Camel Launcher. By default, assume Camel JBang.
+ */
Review Comment:
good catch! thanks! I have adjusted the method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23817: Embed test plugin in Camel launcher [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #24246:
URL: https://github.com/apache/camel/pull/24246#issuecomment-4799282202
Using M2 is fine, no problem, good to know its GA before Camel 4.22 LTS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23817: Embed test plugin in Camel launcher [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24246:
URL: https://github.com/apache/camel/pull/24246#issuecomment-4797888186
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23817: Embed test plugin in Camel launcher [camel]
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on code in PR #24246:
URL: https://github.com/apache/camel/pull/24246#discussion_r3474244421
##########
parent/pom.xml:
##########
@@ -102,7 +102,7 @@
<jta-api-1.2-version>1.2</jta-api-1.2-version>
<chicory-version>1.7.5</chicory-version>
<chunk-templates-version>3.6.2</chunk-templates-version>
- <citrus-version>4.10.1</citrus-version>
+ <citrus-version>5.0.0-M2</citrus-version>
Review Comment:
I am checking if the solution is also working with Citrus 4.10.1 ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23817: Embed test plugin in Camel launcher [camel]
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd merged PR #24246:
URL: https://github.com/apache/camel/pull/24246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23817: Embed test plugin in Camel launcher [camel]
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on code in PR #24246:
URL: https://github.com/apache/camel/pull/24246#discussion_r3473794946
##########
parent/pom.xml:
##########
@@ -102,7 +102,7 @@
<jta-api-1.2-version>1.2</jta-api-1.2-version>
<chicory-version>1.7.5</chicory-version>
<chunk-templates-version>3.6.2</chunk-templates-version>
- <citrus-version>4.10.1</citrus-version>
+ <citrus-version>5.0.0-M2</citrus-version>
Review Comment:
Citrus 5.0.0 GA is planned to be released within the next weeks in July. The M2 milestone is very stable already and if any there are only minor API changes to be expected on the road to GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23817: Embed test plugin in Camel launcher [camel]
Posted by "christophd (via GitHub)" <gi...@apache.org>.
christophd commented on PR #24246:
URL: https://github.com/apache/camel/pull/24246#issuecomment-4798459822
> 3. run command test directory navigation — The old executeRunCommand() automatically navigated to the test/ subdirectory and stripped the test/ prefix from file paths. This logic is removed. Does Citrus 5's Run command handle this internally, or is this a behavioral change for users?
yes, this is now being handled properly in Citrus run command
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23817: Embed test plugin in Camel launcher [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24246:
URL: https://github.com/apache/camel/pull/24246#issuecomment-4798108776
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `dsl/camel-jbang/camel-jbang-plugin-test`
- `dsl/camel-jbang/camel-launcher`
- `parent`
:white_check_mark: **POM dependency changes: targeted tests included**
Changed properties: citrus-version
<details><summary>Modules affected by dependency changes (2)</summary>
- `:camel-jbang-plugin-test`
- `:camel-launcher`
</details>
:bulb: **Manual integration tests recommended:**
> You modified `dsl/camel-jbang/camel-jbang-plugin-test`, `dsl/camel-jbang/camel-launcher`. The related integration tests in `dsl/camel-jbang/camel-jbang-it` are excluded from CI. Consider running them manually:
> ```
> mvn verify -f dsl/camel-jbang/camel-jbang-it -Djbang-it-test
> ```
<details><summary>All tested modules (3 modules)</summary>
- Camel :: JBang :: Plugin :: Testing
- Camel :: Launcher
- Camel :: Launcher :: Container
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/28161365544)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-23817: Embed test plugin in Camel launcher [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #24246:
URL: https://github.com/apache/camel/pull/24246#discussion_r3473580411
##########
dsl/camel-jbang/camel-jbang-plugin-test/src/main/java/org/apache/camel/dsl/jbang/core/commands/test/TestPlugin.java:
##########
@@ -139,50 +163,53 @@ private int executeInitCommand(JBangSupport citrus, List<String> args) {
.formatted(CitrusSettings.getApplicationPropertiesFile(), citrusApplicationProperties));
}
}
+ }
- return execute(citrus, "init", args);
+ /**
+ * Evaluate the current runtime Camel JBang or Camel Launcher. By default, assume Camel JBang.
+ */
Review Comment:
Minor readability note: the double-negative logic (`"false".equals(System.getProperty("camel.launcher", "false"))`) is a bit subtle. A comment or inverting the check (e.g. `isCamelLauncherRuntime()` returning `"true".equals(...)`) might be clearer, though this is just a style observation.
##########
parent/pom.xml:
##########
@@ -102,7 +102,7 @@
<jta-api-1.2-version>1.2</jta-api-1.2-version>
<chicory-version>1.7.5</chicory-version>
<chunk-templates-version>3.6.2</chunk-templates-version>
- <citrus-version>4.10.1</citrus-version>
+ <citrus-version>5.0.0-M2</citrus-version>
Review Comment:
Citrus `4.10.1` (GA) → `5.0.0-M2` (milestone). Milestone releases may have API instability. Is there a timeline for Citrus 5.0.0 GA relative to Camel 4.21?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org