You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/02/25 14:31:32 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #5399: minor: port window tests to slt (part 2)
alamb opened a new pull request, #5399:
URL: https://github.com/apache/arrow-datafusion/pull/5399
# Which issue does this PR close?
Part of #4495
# Rationale for this change
Goal is to make datafusion easier to maintain (e.g. these tests can be updated with `sqllogictest --complete`)
# What changes are included in this PR?
Port 1000 lines of rust code to sqllogictest script
# Are these changes tested?
Yes
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #5399: minor: port window tests to slt (part 2)
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #5399:
URL: https://github.com/apache/arrow-datafusion/pull/5399#issuecomment-1445132962
https://github.com/apache/arrow-datafusion/actions/runs/4269432821/jobs/7432635940
past `window.slt` exist unstable test, maybe we can resolve in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5399: minor: port window tests to slt (part 2)
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5399:
URL: https://github.com/apache/arrow-datafusion/pull/5399#issuecomment-1445343372
Benchmark runs are scheduled for baseline = 69503ea0ffe79cd41575ec7fc80a186904a841b4 and contender = cb09142c7e440e784832e76390711b4ed7bb1c51. cb09142c7e440e784832e76390711b4ed7bb1c51 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/113de1cf4ebc4a61a8ac172a012dc41f...832b1ab8c1a847cfa91dab6240660f86/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c63f66b696474264afa041029672face...0748ee9ae3f2408cbf36f4fdc7a92786/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bd2e26105d144a82ad88e1eae6b36497...442196e95bb94b26bd998b2e7f55d774/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/54b15d06d2ad4395b34a4cd20793169e...fca1a45e2d02495a858a575a4189090b/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #5399: minor: port window tests to slt (part 2)
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #5399:
URL: https://github.com/apache/arrow-datafusion/pull/5399#issuecomment-1445136004
look like this PR also meet this PR😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5399: minor: port window tests to slt (part 2)
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5399:
URL: https://github.com/apache/arrow-datafusion/pull/5399#issuecomment-1445137680
Added a fix in 3c469cc hopefully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5399: minor: port window tests to slt (part 2)
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5399:
URL: https://github.com/apache/arrow-datafusion/pull/5399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org