You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2010/12/02 18:25:46 UTC
svn commit: r1041475 - in /tomcat/trunk/java/org/apache/coyote:
ajp/AbstractAjpProtocol.java http11/AbstractHttp11Protocol.java
Author: markt
Date: Thu Dec 2 17:25:45 2010
New Revision: 1041475
URL: http://svn.apache.org/viewvc?rev=1041475&view=rev
Log:
Remove unnecessary code
Identified by FindBugs
Modified:
tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProtocol.java
tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java
Modified: tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProtocol.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProtocol.java?rev=1041475&r1=1041474&r2=1041475&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProtocol.java Thu Dec 2 17:25:45 2010
@@ -83,12 +83,7 @@ public abstract class AbstractAjpProtoco
*/
public boolean setProperty(String name, String value) {
setAttribute(name, value); //store all settings
- if ( name!=null && (name.startsWith("socket.") ||name.startsWith("selectorPool.")) ){
- return endpoint.setProperty(name, value);
- } else {
- return endpoint.setProperty(name,value); //make sure we at least try to set all properties
- }
-
+ return endpoint.setProperty(name, value);
}
/**
Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java?rev=1041475&r1=1041474&r2=1041475&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Protocol.java Thu Dec 2 17:25:45 2010
@@ -91,12 +91,7 @@ public abstract class AbstractHttp11Prot
*/
public boolean setProperty(String name, String value) {
setAttribute(name, value); //store all settings
- if ( name!=null && (name.startsWith("socket.") ||name.startsWith("selectorPool.")) ){
- return endpoint.setProperty(name, value);
- } else {
- return endpoint.setProperty(name,value); //make sure we at least try to set all properties
- }
-
+ return endpoint.setProperty(name, value);
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org