You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/25 08:02:37 UTC
[GitHub] [shardingsphere] RaigorJiang opened a new pull request, #21741: Fixes #21738, update `RESOURCE` to `STORAGE UNIT` for `REFRESH TABLE METADATA`.
RaigorJiang opened a new pull request, #21741:
URL: https://github.com/apache/shardingsphere/pull/21741
Fixes #21738.
Changes proposed in this pull request:
- Update key words in DistSQL.
- Update document.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21741: Fixes #21738, update `RESOURCE` to `STORAGE UNIT` for `REFRESH TABLE METADATA`.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21741:
URL: https://github.com/apache/shardingsphere/pull/21741#issuecomment-1290298204
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21741?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21741](https://codecov.io/gh/apache/shardingsphere/pull/21741?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e9a1f05) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5c247ec28388c26818651a5269403567ccbb76b0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c247ec) will **decrease** coverage by `0.11%`.
> The diff coverage is `62.50%`.
```diff
@@ Coverage Diff @@
## master #21741 +/- ##
============================================
- Coverage 61.06% 60.94% -0.12%
+ Complexity 2497 2465 -32
============================================
Files 4110 4107 -3
Lines 57386 57314 -72
Branches 9697 9690 -7
============================================
- Hits 35042 34932 -110
- Misses 19433 19477 +44
+ Partials 2911 2905 -6
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ser/core/kernel/KernelDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/21741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL2NvcmUva2VybmVsL0tlcm5lbERpc3RTUUxTdGF0ZW1lbnRWaXNpdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...t/ral/updatable/RefreshTableMetadataStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/21741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL3N0YXRlbWVudC9yYWwvdXBkYXRhYmxlL1JlZnJlc2hUYWJsZU1ldGFkYXRhU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...nt/rql/show/ShowRulesUsedStorageUnitStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/21741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGlzdHNxbC9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2Rpc3RzcWwvcGFyc2VyL3N0YXRlbWVudC9ycWwvc2hvdy9TaG93UnVsZXNVc2VkU3RvcmFnZVVuaXRTdGF0ZW1lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...erter/DatabaseDiscoveryRuleStatementConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/21741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9oYW5kbGVyL2NvbnZlcnRlci9EYXRhYmFzZURpc2NvdmVyeVJ1bGVTdGF0ZW1lbnRDb252ZXJ0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...te/AlterDatabaseDiscoveryRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/21741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9BbHRlckRhdGFiYXNlRGlzY292ZXJ5UnVsZVN0YXRlbWVudFVwZGF0ZXIuamF2YQ==) | `86.95% <ø> (+0.16%)` | :arrow_up: |
| [...e/CreateDatabaseDiscoveryRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/21741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9DcmVhdGVEYXRhYmFzZURpc2NvdmVyeVJ1bGVTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `74.28% <ø> (-4.29%)` | :arrow_down: |
| [...core/DatabaseDiscoveryDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/21741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvcGFyc2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9kaXN0c3FsL3BhcnNlci9jb3JlL0RhdGFiYXNlRGlzY292ZXJ5RGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...sql/ral/RefreshTableMetadataStatementTestCase.java](https://codecov.io/gh/apache/shardingsphere/pull/21741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9wYXJhbWV0ZXJpemVkL2pheGIvY2FzZXMvZG9tYWluL3N0YXRlbWVudC9kaXN0c3FsL3JhbC9SZWZyZXNoVGFibGVNZXRhZGF0YVN0YXRlbWVudFRlc3RDYXNlLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sql/ral/updatable/RefreshTableMetadataHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/21741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3VwZGF0YWJsZS9SZWZyZXNoVGFibGVNZXRhZGF0YUhhbmRsZXIuamF2YQ==) | `70.37% <62.50%> (ø)` | |
| [...l/rql/rule/RulesUsedStorageUnitQueryResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/21741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcnFsL3J1bGUvUnVsZXNVc2VkU3RvcmFnZVVuaXRRdWVyeVJlc3VsdFNldC5qYXZh) | `89.83% <100.00%> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/shardingsphere/pull/21741/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] soulasuna merged pull request #21741: Fixes #21738, update `RESOURCE` to `STORAGE UNIT` for `REFRESH TABLE METADATA`.
Posted by GitBox <gi...@apache.org>.
soulasuna merged PR #21741:
URL: https://github.com/apache/shardingsphere/pull/21741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org