[GitHub] [incubator-superset] kristw commented on a change in pull request #7386: Updating contributing/install docs

[GitBox <gi...@apache.org>]

kristw commented on a change in pull request #7386: Updating contributing/install docs
URL: https://github.com/apache/incubator-superset/pull/7386#discussion_r279824732
 
 

 ##########
 File path: CONTRIBUTING.md
 ##########
 @@ -293,20 +293,58 @@ python setup.py build_sphinx
 
 ### Flask server
 
-Make sure your machine meets the [OS dependencies](https://superset.incubator.apache.org/installation.html#os-dependencies) before following these steps.
+#### OS Dependencies
+
+Make sure your machine meets the [OS dependencies](https://superset.incubator.apache.org/installation.html#os-dependencies) before following these steps. 
+
+In addition you will need to install the mysql client to get mysql_config, which is required by mysqlclient in requirements-dev.txt.
+
+For Debian/Ubuntu:
+
+```bash
+sudo apt-get install -y libmysqlclient-dev
+```
+
+For OS X via brew:
+
+```bash
+brew install mysql-client
+echo 'export PATH="/usr/local/opt/mysql-client/bin:$PATH"' >> ~/.bash_profile
+source ~/.bash_profile
+```
+
+Developers should use a virtualenv. Anaconda Python users should make sure that conda installs the virtualenv package, otherwise conda packages won't play well with packages installed by pip. In addition, Anaconda Python installs its own version of certifi that must be removed minus dependencies for requirements.txt's certifi to install.
 
 Review comment:
   +1 @mistercrunch I would prefer to keep the instructions as simple and require the least dependencies possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org