You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/18 16:09:18 UTC

[GitHub] [airflow] ashb commented on a change in pull request #5589: [AIRFLOW-4956] Fix LocalTaskJob heartbeat log spamming

ashb commented on a change in pull request #5589: [AIRFLOW-4956] Fix LocalTaskJob heartbeat log spamming
URL: https://github.com/apache/airflow/pull/5589#discussion_r305001099
 
 

 ##########
 File path: UPDATING.md
 ##########
 @@ -23,6 +23,11 @@ assists users migrating to a new version.
 
 ## Airflow Master
 
+### Removal of StatsD metrics `local_task_job_heartbeat_failure`
+
+New metrics named `lower(JobClassName)_heartbeat_failure` will replacing the removed metric.
 
 Review comment:
   It's now `localtaskjob_heartbeat_failure`, right? Could you add that example?
   
   Or we could keep the pattern the same to make this a seamless upgrade:
   
   ```
   re.sub('(?!^)([A-Z]+)', r'_\1', self.__class__.__name__).lower()
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services