You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Robert Kanter (JIRA)" <ji...@apache.org> on 2012/10/25 22:35:12 UTC
[jira] [Created] (OOZIE-1035) Improve forkjoin validation to allow
same errorTo transitions
Robert Kanter created OOZIE-1035:
------------------------------------
Summary: Improve forkjoin validation to allow same errorTo transitions
Key: OOZIE-1035
URL: https://issues.apache.org/jira/browse/OOZIE-1035
Project: Oozie
Issue Type: Improvement
Components: workflow
Affects Versions: trunk
Reporter: Robert Kanter
Assignee: Robert Kanter
Priority: Minor
Fix For: trunk
It seems common that users will have the "error to" transition from every action go to the same action node (e.g. email action), which then goes to the kill node instead of just going to the kill node directly. When this is done in action nodes within a forkjoin path, the forkjoin validation doesn't allow it. We should improve the forkjoin validation code to allow the same "error to" transition, as long as it eventually leads to a kill or end node.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-1035) Improve forkjoin validation to
allow same errorTo transitions
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490828#comment-13490828 ]
Hadoop QA commented on OOZIE-1035:
----------------------------------
Testing JIRA OOZIE-1035
Cleaning local svn workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 132
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 916
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/163/
> Improve forkjoin validation to allow same errorTo transitions
> -------------------------------------------------------------
>
> Key: OOZIE-1035
> URL: https://issues.apache.org/jira/browse/OOZIE-1035
> Project: Oozie
> Issue Type: Improvement
> Components: workflow
> Affects Versions: trunk
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Minor
> Fix For: trunk
>
> Attachments: OOZIE-1035.patch
>
>
> It seems common that users will have the "error to" transition from every action go to the same action node (e.g. email action), which then goes to the kill node instead of just going to the kill node directly. When this is done in action nodes within a forkjoin path, the forkjoin validation doesn't allow it. We should improve the forkjoin validation code to allow the same "error to" transition, as long as it eventually leads to a kill or end node.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-1035) Improve forkjoin validation to allow
same errorTo transitions
Posted by "Robert Kanter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Kanter updated OOZIE-1035:
---------------------------------
Attachment: OOZIE-1035.patch
I rewrote the forkjoin validation; it's much more lenient now. It essentially just checks that every path from a fork eventually goes to an associated join. I also updated the tests and added a new one.
> Improve forkjoin validation to allow same errorTo transitions
> -------------------------------------------------------------
>
> Key: OOZIE-1035
> URL: https://issues.apache.org/jira/browse/OOZIE-1035
> Project: Oozie
> Issue Type: Improvement
> Components: workflow
> Affects Versions: trunk
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Minor
> Fix For: trunk
>
> Attachments: OOZIE-1035.patch
>
>
> It seems common that users will have the "error to" transition from every action go to the same action node (e.g. email action), which then goes to the kill node instead of just going to the kill node directly. When this is done in action nodes within a forkjoin path, the forkjoin validation doesn't allow it. We should improve the forkjoin validation code to allow the same "error to" transition, as long as it eventually leads to a kill or end node.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira