[GitHub] [solr] risdenk commented on a change in pull request #731: SOLR-15223 Limit use of org.apache.http

[GitBox <gi...@apache.org>]

risdenk commented on a change in pull request #731:
URL: https://github.com/apache/solr/pull/731#discussion_r820316916



##########
File path: solr/solrj/src/java/org/apache/solr/common/util/ContentStreamBase.java
##########
@@ -47,11 +46,13 @@
 
   public static final String DEFAULT_CHARSET = StandardCharsets.UTF_8.name();
   private static final String TEXT_CSV = "text/csv";
+  public static final String TEXT_XML = "text/xml";
+  public static final String APPLICATION_OCTET_STREAM = "application/octet-stream";
+  public static final String APPLICATION_GZIP = "application/gzip";
+  public static final String APPLICATION_XML = "application/xml";
+  public static final String APPLICATION_JSON = "application/json";

Review comment:
       I'm not sure all these are needed? It looks like https://www.eclipse.org/jetty/javadoc/jetty-10/org/eclipse/jetty/http/MimeTypes.Type.html has replacements for these constants?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org