You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2025/04/24 03:10:23 UTC

[PR] [FLINK-37716] Simplify YarnClusterDescriptor by removing parameter JobGraph [flink]

beliefer opened a new pull request, #26500:
URL: https://github.com/apache/flink/pull/26500

   ## What is the purpose of the change
   
   This PR aims to simplify YarnClusterDescriptor by removing parameter JobGraph
   
   
   ## Brief change log
   
   Simplify YarnClusterDescriptor by removing parameter JobGraph
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37716] Simplify YarnClusterDescriptor by removing parameter JobGraph [flink]

Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26500:
URL: https://github.com/apache/flink/pull/26500#discussion_r2070403876


##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:
##########
@@ -899,14 +889,6 @@ private ApplicationReport startAppMaster(
         }
 
         final Set<Path> userJarFiles = new HashSet<>();
-        if (jobGraph != null) {

Review Comment:
   I see that the variable is not null, I wonder if jobGraphs are intended to come in in the near future, i would prefer to defer to an owner in this area to decide whether they want this change  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37716] Simplify YarnClusterDescriptor by removing parameter JobGraph [flink]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #26500:
URL: https://github.com/apache/flink/pull/26500#discussion_r2074656925


##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:
##########
@@ -899,14 +889,6 @@ private ApplicationReport startAppMaster(
         }
 
         final Set<Path> userJarFiles = new HashSet<>();
-        if (jobGraph != null) {

Review Comment:
   Thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37716] Simplify YarnClusterDescriptor by removing parameter JobGraph [flink]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #26500:
URL: https://github.com/apache/flink/pull/26500#issuecomment-2827431124

   ping @tisonkun @kl0u cc @1996fanrui @davidradl @GOODBOY008 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37716] Simplify YarnClusterDescriptor by removing parameter JobGraph [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #26500: [FLINK-37716] Simplify YarnClusterDescriptor by removing parameter JobGraph
URL: https://github.com/apache/flink/pull/26500


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37716] Simplify YarnClusterDescriptor by removing parameter JobGraph [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26500:
URL: https://github.com/apache/flink/pull/26500#issuecomment-4629323132

   This PR has been closed since it has not had any activity in 120 days. 
   If you feel like this was a mistake, or you would like to continue working on it, 
   please feel free to re-open the PR and ask for a review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37716] Simplify YarnClusterDescriptor by removing parameter JobGraph [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26500:
URL: https://github.com/apache/flink/pull/26500#issuecomment-2826200731

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b6bbbb357540cbf82ffea23cb00a2dc7740005bc",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b6bbbb357540cbf82ffea23cb00a2dc7740005bc",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b6bbbb357540cbf82ffea23cb00a2dc7740005bc UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37716] Simplify YarnClusterDescriptor by removing parameter JobGraph [flink]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26500:
URL: https://github.com/apache/flink/pull/26500#issuecomment-4385868638

   This PR is being marked as stale since it has not had any activity in the last 90 days. 
   If you would like to keep this PR alive, please leave a comment asking for a review. 
   If the PR has merge conflicts, update it with the latest from the base branch.
   
   If you are having difficulty finding a reviewer, please reach out to the 
   community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
   
   If this PR is no longer valid or desired, please feel free to close it. 
   If no activity occurs in the next 30 days, it will be automatically closed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org