You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/31 10:52:42 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #13392: Add upgrade check option to list checks

turbaszek commented on a change in pull request #13392:
URL: https://github.com/apache/airflow/pull/13392#discussion_r550456400



##########
File path: airflow/upgrade/checker.py
##########
@@ -41,6 +41,15 @@ def check_upgrade(formatter, rules):
     return all_rule_statuses
 
 
+def list_checks():
+    print()
+    print("Upgrade Checks:")
+    for rule in ALL_RULES:

Review comment:
       ```suggestion
       for rule in sorted(ALL_RULES, key=lambda r: r.__class__.__name__:
   ```
   
   This will introduce a nice order. In fact we can even use this `sorted` in definition of `ALL_RULES` to keep it sorted everywhere, WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org