You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "gyowoo1113 (via GitHub)" <gi...@apache.org> on 2026/05/02 12:09:52 UTC
[PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
gyowoo1113 opened a new pull request, #66272:
URL: https://github.com/apache/airflow/pull/66272
## Summary
Added Korean translations for deadline status labels in the DAG UI:
- `missed` : "미준수
- `missedCount_one/other` : 데드라인 미준수 {{count}}건
- `mixedCount` : `데드라인 미준수 {{missedCount}}건, 예정 {{upcomingCount}}건
---
## Changes
- Updated airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on code in PR #66272:
URL: https://github.com/apache/airflow/pull/66272#discussion_r3192508868
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -47,6 +47,10 @@
"finishedLate": "데드라인보다 {{duration}} 늦게 완료",
"label": "데드라인",
"met": "달성",
+ "missed": "초과",
+ "missedCount_one": "데드라인 초과 {{count}}개",
+ "missedCount_other": "데드라인 초과 {{count}}개",
Review Comment:
```suggestion
"missedCount_one": "데드라인 초과 {{count}}건",
"missedCount_other": "데드라인 초과 {{count}}건",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "gyowoo1113 (via GitHub)" <gi...@apache.org>.
gyowoo1113 commented on PR #66272:
URL: https://github.com/apache/airflow/pull/66272#issuecomment-4364918782
> 👍 How about translation 경과 for Missed, instead of 미준수?
Thanks for the suggestion!
I’ve updated the `missed` deadline status translation from `미준수` to `초과`, as it seems to better fit the deadline status context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "kkumtree (via GitHub)" <gi...@apache.org>.
kkumtree commented on code in PR #66272:
URL: https://github.com/apache/airflow/pull/66272#discussion_r3181400968
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -40,6 +40,12 @@
"parseDuration": "파싱 기간:",
"parsedAt": "파싱 시간:"
},
+ "deadlineStatus": {
+ "missed": "초과",
+ "missedCount_one": "데드라인 초과 {{count}}건",
+ "missedCount_other": "데드라인 초과 {{count}}건",
Review Comment:
@parkhojeong said that using `개` instaead of `건` for counting deadlines.
https://github.com/apache/airflow/pull/66274#discussion_r3177657063
Could you edit this word?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on code in PR #66272:
URL: https://github.com/apache/airflow/pull/66272#discussion_r3192672837
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -47,6 +47,10 @@
"finishedLate": "데드라인보다 {{duration}} 늦게 완료",
"label": "데드라인",
"met": "달성",
+ "missed": "초과",
+ "missedCount_one": "데드라인 초과 {{count}}건",
+ "missedCount_other": "데드라인 초과 {{count}}건",
+ "mixedCount": "데드라인 초과 {{missedCount}}개, 예정 {{upcomingCount}}개",
Review Comment:
```suggestion
"mixedCount": "데드라인 초과 {{missedCount}}건, 예정 {{upcomingCount}}건",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on code in PR #66272:
URL: https://github.com/apache/airflow/pull/66272#discussion_r3186644676
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -40,6 +40,12 @@
"parseDuration": "파싱 기간:",
"parsedAt": "파싱 시간:"
},
+ "deadlineStatus": {
+ "missed": "초과",
+ "missedCount_one": "데드라인 초과 {{count}}건",
+ "missedCount_other": "데드라인 초과 {{count}}건",
Review Comment:
<img width="324" height="217" alt="Image" src="https://github.com/user-attachments/assets/aa012d10-603a-4b27-ac70-052b6db24e16" />
In this context, “건” would be more appropriate than “개.”
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #66272:
URL: https://github.com/apache/airflow/pull/66272#discussion_r3186154831
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -40,6 +40,12 @@
"parseDuration": "파싱 기간:",
"parsedAt": "파싱 시간:"
},
+ "deadlineStatus": {
+ "missed": "초과",
+ "missedCount_one": "데드라인 초과 {{count}}건",
+ "missedCount_other": "데드라인 초과 {{count}}건",
Review Comment:
the link @kkumtree left refers the page because comment is resolved
i left screenshot
<img width="788" height="604" alt="image" src="https://github.com/user-attachments/assets/4ff9eaa0-47bc-464b-88c4-34841b224f52" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #66272:
URL: https://github.com/apache/airflow/pull/66272#issuecomment-4384674821
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on PR #66272:
URL: https://github.com/apache/airflow/pull/66272#issuecomment-4378302454
> @kkumtree Thank you for the review!
>
> I’ve updated 건 to 개 in the deadline count wording.
I found the definition Based on 국립국어원
- 건(의존명사 2): 사건, 서류, 안건 따위를 세는 단위.
- 예: 교통사고가 일곱 건이나 일어났다.
- 개(의존명사): 낱으로 된 물건을 세는 단위.
- 예: 사탕 한 개, 사과 몇 개
건 is more natural because it is a kind of 사건.
@choo121600 also might say it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #66272:
URL: https://github.com/apache/airflow/pull/66272#discussion_r3186154831
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -40,6 +40,12 @@
"parseDuration": "파싱 기간:",
"parsedAt": "파싱 시간:"
},
+ "deadlineStatus": {
+ "missed": "초과",
+ "missedCount_one": "데드라인 초과 {{count}}건",
+ "missedCount_other": "데드라인 초과 {{count}}건",
Review Comment:
the link @kkumtree left refers the page because comment is resolved
i left screenshot.
<img width="788" height="604" alt="image" src="https://github.com/user-attachments/assets/4ff9eaa0-47bc-464b-88c4-34841b224f52" />
you can see a suggestion https://github.com/apache/airflow/pull/66272#discussion_r3183477339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #66272:
URL: https://github.com/apache/airflow/pull/66272#discussion_r3186154831
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -40,6 +40,12 @@
"parseDuration": "파싱 기간:",
"parsedAt": "파싱 시간:"
},
+ "deadlineStatus": {
+ "missed": "초과",
+ "missedCount_one": "데드라인 초과 {{count}}건",
+ "missedCount_other": "데드라인 초과 {{count}}건",
Review Comment:
the link @kkumtree left refers the page because comment is resolved
i left screenshot.
<img width="788" height="604" alt="image" src="https://github.com/user-attachments/assets/4ff9eaa0-47bc-464b-88c4-34841b224f52" />
you can use my suggestion https://github.com/apache/airflow/pull/66272#discussion_r3183477339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #66272:
URL: https://github.com/apache/airflow/pull/66272#discussion_r3183477339
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -40,6 +40,12 @@
"parseDuration": "파싱 기간:",
"parsedAt": "파싱 시간:"
},
+ "deadlineStatus": {
+ "missed": "초과",
+ "missedCount_one": "데드라인 초과 {{count}}건",
+ "missedCount_other": "데드라인 초과 {{count}}건",
+ "mixedCount": "데드라인 초과 {{missedCount}}건, 예정 {{upcomingCount}}건"
Review Comment:
```suggestion
"missedCount_one": "데드라인 초과 {{count}}개",
"missedCount_other": "데드라인 초과 {{count}}개",
"mixedCount": "데드라인 초과 {{missedCount}}개, 예정 {{upcomingCount}}개"
```
lgtm overall !
`개` is fit on existing translations (@kkumtree said this https://github.com/apache/airflow/pull/66274#discussion_r3177657063)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "gyowoo1113 (via GitHub)" <gi...@apache.org>.
gyowoo1113 commented on PR #66272:
URL: https://github.com/apache/airflow/pull/66272#issuecomment-4378008808
@kkumtree Thank you for the review!
I’ve updated 건 to 개 in the deadline count wording.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #66272:
URL: https://github.com/apache/airflow/pull/66272#discussion_r3186154831
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -40,6 +40,12 @@
"parseDuration": "파싱 기간:",
"parsedAt": "파싱 시간:"
},
+ "deadlineStatus": {
+ "missed": "초과",
+ "missedCount_one": "데드라인 초과 {{count}}건",
+ "missedCount_other": "데드라인 초과 {{count}}건",
Review Comment:
i left suggestions and comment link https://github.com/apache/airflow/pull/66272#discussion_r3183477339 that @kkumtree mentioned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #66272:
URL: https://github.com/apache/airflow/pull/66272#issuecomment-4363748826
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #66272:
URL: https://github.com/apache/airflow/pull/66272#discussion_r3183477339
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -40,6 +40,12 @@
"parseDuration": "파싱 기간:",
"parsedAt": "파싱 시간:"
},
+ "deadlineStatus": {
+ "missed": "초과",
+ "missedCount_one": "데드라인 초과 {{count}}건",
+ "missedCount_other": "데드라인 초과 {{count}}건",
+ "mixedCount": "데드라인 초과 {{missedCount}}건, 예정 {{upcomingCount}}건"
Review Comment:
```suggestion
"missedCount_one": "데드라인 초과 {{count}}개",
"missedCount_other": "데드라인 초과 {{count}}개",
"mixedCount": "데드라인 초과 {{missedCount}}개, 예정 {{upcomingCount}}개"
```
lgtm overall !
개 fits the existing translations (@kkumtree said this https://github.com/apache/airflow/pull/66274#discussion_r3177657063)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #66272:
URL: https://github.com/apache/airflow/pull/66272#discussion_r3183477339
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -40,6 +40,12 @@
"parseDuration": "파싱 기간:",
"parsedAt": "파싱 시간:"
},
+ "deadlineStatus": {
+ "missed": "초과",
+ "missedCount_one": "데드라인 초과 {{count}}건",
+ "missedCount_other": "데드라인 초과 {{count}}건",
+ "mixedCount": "데드라인 초과 {{missedCount}}건, 예정 {{upcomingCount}}건"
Review Comment:
```suggestion
"missedCount_one": "데드라인 초과 {{count}}개",
"missedCount_other": "데드라인 초과 {{count}}개",
"mixedCount": "데드라인 초과 {{missedCount}}개, 예정 {{upcomingCount}}개"
```
lgtm overall !
개 fits the existing translations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 merged PR #66272:
URL: https://github.com/apache/airflow/pull/66272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #66272:
URL: https://github.com/apache/airflow/pull/66272#discussion_r3186154831
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -40,6 +40,12 @@
"parseDuration": "파싱 기간:",
"parsedAt": "파싱 시간:"
},
+ "deadlineStatus": {
+ "missed": "초과",
+ "missedCount_one": "데드라인 초과 {{count}}건",
+ "missedCount_other": "데드라인 초과 {{count}}건",
Review Comment:
link @kkumtree left refer page not comment
i left the direct link for comment https://github.com/apache/airflow/pull/66274#discussion_r3177657063
##########
airflow-core/src/airflow/ui/public/i18n/locales/ko/dag.json:
##########
@@ -40,6 +40,12 @@
"parseDuration": "파싱 기간:",
"parsedAt": "파싱 시간:"
},
+ "deadlineStatus": {
+ "missed": "초과",
+ "missedCount_one": "데드라인 초과 {{count}}건",
+ "missedCount_other": "데드라인 초과 {{count}}건",
Review Comment:
link @kkumtree left refers the page not comment
i left the direct link for comment https://github.com/apache/airflow/pull/66274#discussion_r3177657063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] i18n(ko): Add translations for DAG deadline status (May 2) [airflow]
Posted by "kkumtree (via GitHub)" <gi...@apache.org>.
kkumtree commented on PR #66272:
URL: https://github.com/apache/airflow/pull/66272#issuecomment-4363756590
:+1: How about translation `경과` for `Missed`, instead of `미준수`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org