You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "okaybase (via GitHub)" <gi...@apache.org> on 2023/04/18 15:34:01 UTC
[GitHub] [apisix] okaybase opened a new pull request, #9332: fix: parse domain when the service's pod ip changes
okaybase opened a new pull request, #9332:
URL: https://github.com/apache/apisix/pull/9332
### Description
Plugin: traffic-split
Use a service-name as the host of weighted_upstreams's nodes, when redeploying the service (the pods ip changes), will result in the request 502.
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on pull request #9332: fix: parse domain when the service's pod ip changes
Posted by "leslie-tsang (via GitHub)" <gi...@apache.org>.
leslie-tsang commented on PR #9332:
URL: https://github.com/apache/apisix/pull/9332#issuecomment-1514035499
Hello there, need a test case to make sure it was fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] okaybase commented on pull request #9332: fix: always parse domain when host is domain name
Posted by "okaybase (via GitHub)" <gi...@apache.org>.
okaybase commented on PR #9332:
URL: https://github.com/apache/apisix/pull/9332#issuecomment-1535259346
> Try to merge the master branch
merged~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9332: fix: always parse domain when host is domain name
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #9332:
URL: https://github.com/apache/apisix/pull/9332#issuecomment-1535008385
@okaybase please make the ci pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 merged pull request #9332: fix: always parse domain when host is domain name
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 merged PR #9332:
URL: https://github.com/apache/apisix/pull/9332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] okaybase commented on pull request #9332: fix: parse domain when the service's pod ip changes
Posted by "okaybase (via GitHub)" <gi...@apache.org>.
okaybase commented on PR #9332:
URL: https://github.com/apache/apisix/pull/9332#issuecomment-1515606695
> Hello there, need a test case to make sure it was fixed.
okay, i write the test case later, thanks ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] okaybase commented on pull request #9332: fix: always parse domain when host is domain name
Posted by "okaybase (via GitHub)" <gi...@apache.org>.
okaybase commented on PR #9332:
URL: https://github.com/apache/apisix/pull/9332#issuecomment-1535261401
> @okaybase please make the ci pass
okay, done~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9332: fix: always parse domain when host is domain name
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #9332:
URL: https://github.com/apache/apisix/pull/9332#issuecomment-1535079511
Try to merge the master branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org