You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sjperkins (via GitHub)" <gi...@apache.org> on 2023/05/04 08:53:44 UTC
[GitHub] [arrow] sjperkins opened a new pull request, #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
sjperkins opened a new pull request, #35430:
URL: https://github.com/apache/arrow/pull/35430
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
- https://github.com/apache/arrow/pull/34818 pinned vcpkg to a non-release master branch commit.
- This was to include unreleased changes, specifically https://github.com/microsoft/vcpkg/issues/29674.
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
This pins vcpkg to the official 2023.04.15 release (commit https://github.com/microsoft/vcpkg/commit/501db0f17ef6df184fcdbfbe0f87cde2313b6ab1)
### Are these changes tested?
I've successfully test that the following local wheel builds succeed:
```bash
$ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2014
$ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2-28
```
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
I don't believe so
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35430:
URL: https://github.com/apache/arrow/pull/35430#issuecomment-1536756434
Ah, the `java-jars` nightly builds on main were failed since 2023-05-05:
https://lists.apache.org/list.html?builds@arrow.apache.org
2023-05-04: https://github.com/ursacomputing/crossbow/actions/runs/4880720274/jobs/8715652875
2023-05-05: https://github.com/ursacomputing/crossbow/actions/runs/4891509316/jobs/8732835157
So I think that the failure isn't related to this PR.
Could you open an issue for the failure? Then we can merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35430:
URL: https://github.com/apache/arrow/pull/35430#issuecomment-1537540513
I want to check whether https://github.com/ursacomputing/crossbow/actions/runs/4906241298/jobs/8760550661#step:7:1397 is caused by this or not:
```text
CMake Error at scripts/cmake/z_vcpkg_apply_patches.cmake:34 (message):
Applying patch failed: error: corrupt patch at line 18
Call Stack (most recent call first):
scripts/cmake/vcpkg_extract_source_archive.cmake:153 (z_vcpkg_apply_patches)
scripts/cmake/vcpkg_extract_source_archive_ex.cmake:8 (vcpkg_extract_source_archive)
scripts/cmake/vcpkg_from_github.cmake:113 (vcpkg_extract_source_archive_ex)
ports/snappy/portfile.cmake:4 (vcpkg_from_github)
scripts/ports.cmake:147 (include)
error: building snappy:amd64-windows-static-md-release failed with: BUILD_FAILED
Please ensure you're using the latest port files with `git pull` and `vcpkg update`.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+snappy
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?title=[snappy]+Build+error&body=Copy+issue+body+from+C%3A%2Fvcpkg%2Finstalled%2Fvcpkg%2Fissue_body.md
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #35430:
URL: https://github.com/apache/arrow/pull/35430#discussion_r1184766301
##########
ci/vcpkg/ports.patch:
##########
@@ -49,18 +49,5 @@ index 0000000000..a57ce0c22f
+ return v & ~(mask << (8 * n));
+-#endif
+ }
-+
++
+ static inline bool LeftShiftOverflows(uint8_t value, uint32_t shift) {
-diff --git a/scripts/cmake/vcpkg_find_acquire_program.cmake b/scripts/cmake/vcpkg_find_acquire_program.cmake
-index 4611af6..d11936f 100644
---- a/scripts/cmake/vcpkg_find_acquire_program.cmake
-+++ b/scripts/cmake/vcpkg_find_acquire_program.cmake
-@@ -239,7 +239,7 @@ function(vcpkg_find_acquire_program program)
- set(paths_to_search "${DOWNLOADS}/tools/python/${tool_subdirectory}")
- vcpkg_list(SET post_install_command "${CMAKE_COMMAND}" -E rm python310._pth)
- else()
-- set(program_name python3)
-+ set(program_name python)
- set(brew_package_name "python")
- set(apt_package_name "python3")
- endif()
Review Comment:
Oh, sorry. I've done it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35430:
URL: https://github.com/apache/arrow/pull/35430#issuecomment-1537540277
@github-actions crossbow submit wheel-windows-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sjperkins commented on a diff in pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "sjperkins (via GitHub)" <gi...@apache.org>.
sjperkins commented on code in PR #35430:
URL: https://github.com/apache/arrow/pull/35430#discussion_r1184737729
##########
ci/vcpkg/ports.patch:
##########
@@ -49,18 +49,5 @@ index 0000000000..a57ce0c22f
+ return v & ~(mask << (8 * n));
+-#endif
+ }
-+
++
+ static inline bool LeftShiftOverflows(uint8_t value, uint32_t shift) {
-diff --git a/scripts/cmake/vcpkg_find_acquire_program.cmake b/scripts/cmake/vcpkg_find_acquire_program.cmake
-index 4611af6..d11936f 100644
---- a/scripts/cmake/vcpkg_find_acquire_program.cmake
-+++ b/scripts/cmake/vcpkg_find_acquire_program.cmake
-@@ -239,7 +239,7 @@ function(vcpkg_find_acquire_program program)
- set(paths_to_search "${DOWNLOADS}/tools/python/${tool_subdirectory}")
- vcpkg_list(SET post_install_command "${CMAKE_COMMAND}" -E rm python310._pth)
- else()
-- set(program_name python3)
-+ set(program_name python)
- set(brew_package_name "python")
- set(apt_package_name "python3")
- endif()
Review Comment:
The above patch no longer cleanly applies due to https://github.com/microsoft/vcpkg/pull/30780.
Having removed it, the following local builds succeed.
```bash
$ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2014
$ ARCH=amd64 PYTHON=3.10 archery docker run python-wheel-manylinux-2-28
```
However, it's probably worth running the entire suite to check if everything is OK
##########
.env:
##########
@@ -92,12 +92,7 @@ DEVTOOLSET_VERSION=
# Used through docker-compose.yml and serves as the default version for the
# ci/scripts/install_vcpkg.sh script. Prefer to use short SHAs to keep the
# docker tags more readable.
-#
-# Please also update the crossbow configuration in order to keep the github
-# actions cache up to date for the macOS wheels:
-# https://github.com/ursacomputing/crossbow/blob/master/.github/workflows/cache_vcpkg.yml
-# TODO: Update to an official release tag https://github.com/apache/arrow/issues/35099
Review Comment:
Removed due to suggestion here: https://github.com/apache/arrow/pull/34818#discussion_r1184321238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35430:
URL: https://github.com/apache/arrow/pull/35430#issuecomment-1534387108
Revision: 996cd86726477fd337459b59dad2a97abc25fb18
Submitted crossbow builds: [ursacomputing/crossbow @ actions-821498ff0c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-821498ff0c)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4881153113/jobs/8709700482)|
|wheel-manylinux-2-28-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881151811/jobs/8709695720)|
|wheel-manylinux-2-28-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881153610/jobs/8709699263)|
|wheel-manylinux-2-28-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881152109/jobs/8709696130)|
|wheel-manylinux-2-28-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881156131/jobs/8709705148)|
|wheel-manylinux-2-28-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881155485/jobs/8709703682)|
|wheel-manylinux-2-28-cp37-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881156653/jobs/8709706388)|
|wheel-manylinux-2-28-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881155902/jobs/8709704621)|
|wheel-manylinux-2-28-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881153946/jobs/8709700009)|
|wheel-manylinux-2-28-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881152658/jobs/8709697259)|
|wheel-manylinux-2-28-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881152887/jobs/8709697716)|
|wheel-manylinux-2014-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881153345/jobs/8709698726)|
|wheel-manylinux-2014-cp310-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881155069/jobs/8709702691)|
|wheel-manylinux-2014-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881154814/jobs/8709702048)|
|wheel-manylinux-2014-cp311-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881154384/jobs/8709701013)|
|wheel-manylinux-2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881157061/jobs/8709707105)|
|wheel-manylinux-2014-cp37-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881154632/jobs/8709701498)|
|wheel-manylinux-2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881152541/jobs/8709696948)|
|wheel-manylinux-2014-cp38-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881155278/jobs/8709703170)|
|wheel-manylinux-2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881155672/jobs/8709704155)|
|wheel-manylinux-2014-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4881154177/jobs/8709700505)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35430:
URL: https://github.com/apache/arrow/pull/35430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35430:
URL: https://github.com/apache/arrow/pull/35430#issuecomment-1535779291
I've re-ran it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35430:
URL: https://github.com/apache/arrow/pull/35430#issuecomment-1534336371
* Closes: #35099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sjperkins commented on pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "sjperkins (via GitHub)" <gi...@apache.org>.
sjperkins commented on PR #35430:
URL: https://github.com/apache/arrow/pull/35430#issuecomment-1539619155
> wheel-windows-cp37-amd64
Looks like it may have. I've opened https://github.com/apache/arrow/issues/35503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sjperkins commented on pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "sjperkins (via GitHub)" <gi...@apache.org>.
sjperkins commented on PR #35430:
URL: https://github.com/apache/arrow/pull/35430#issuecomment-1537108531
> Could you open an issue for the failure? Then we can merge this.
https://github.com/apache/arrow/issues/35463 opened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35430:
URL: https://github.com/apache/arrow/pull/35430#issuecomment-1534378735
@github-actions crossbow submit wheel-manylinux-* java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sjperkins commented on a diff in pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "sjperkins (via GitHub)" <gi...@apache.org>.
sjperkins commented on code in PR #35430:
URL: https://github.com/apache/arrow/pull/35430#discussion_r1184795573
##########
ci/vcpkg/ports.patch:
##########
@@ -49,18 +49,5 @@ index 0000000000..a57ce0c22f
+ return v & ~(mask << (8 * n));
+-#endif
+ }
-+
++
+ static inline bool LeftShiftOverflows(uint8_t value, uint32_t shift) {
-diff --git a/scripts/cmake/vcpkg_find_acquire_program.cmake b/scripts/cmake/vcpkg_find_acquire_program.cmake
-index 4611af6..d11936f 100644
---- a/scripts/cmake/vcpkg_find_acquire_program.cmake
-+++ b/scripts/cmake/vcpkg_find_acquire_program.cmake
-@@ -239,7 +239,7 @@ function(vcpkg_find_acquire_program program)
- set(paths_to_search "${DOWNLOADS}/tools/python/${tool_subdirectory}")
- vcpkg_list(SET post_install_command "${CMAKE_COMMAND}" -E rm python310._pth)
- else()
-- set(program_name python3)
-+ set(program_name python)
- set(brew_package_name "python")
- set(apt_package_name "python3")
- endif()
Review Comment:
> Oh, sorry. I've done it!
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #35430:
URL: https://github.com/apache/arrow/pull/35430#discussion_r1184764929
##########
.env:
##########
@@ -92,12 +92,7 @@ DEVTOOLSET_VERSION=
# Used through docker-compose.yml and serves as the default version for the
# ci/scripts/install_vcpkg.sh script. Prefer to use short SHAs to keep the
# docker tags more readable.
-#
-# Please also update the crossbow configuration in order to keep the github
-# actions cache up to date for the macOS wheels:
-# https://github.com/ursacomputing/crossbow/blob/master/.github/workflows/cache_vcpkg.yml
-# TODO: Update to an official release tag https://github.com/apache/arrow/issues/35099
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sjperkins commented on pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "sjperkins (via GitHub)" <gi...@apache.org>.
sjperkins commented on PR #35430:
URL: https://github.com/apache/arrow/pull/35430#issuecomment-1535772275
All green, except for the `java-jars` which looks to be related to a maven timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sjperkins commented on pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "sjperkins (via GitHub)" <gi...@apache.org>.
sjperkins commented on PR #35430:
URL: https://github.com/apache/arrow/pull/35430#issuecomment-1535890841
Failed again. On both occasions it seems related to transfer of the maven shade plugin?
```
Error: Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.1.1:shade (default) on project arrow-vector:
Execution default of goal org.apache.maven.plugins:maven-shade-plugin:3.1.1:shade failed:
Plugin org.apache.maven.plugins:maven-shade-plugin:3.1.1 or one of its dependencies could not be resolved:
Failed to collect dependencies at org.apache.maven.plugins:maven-shade-plugin:jar:3.1.1 -> org.ow2.asm:asm:jar:6.0:
Failed to read artifact descriptor for org.ow2.asm:asm:jar:6.0:
The following artifacts could not be resolved: org.ow2.asm:asm:pom:6.0 (absent):
Could not transfer artifact org.ow2.asm:asm:pom:6.0 from/to apache (https://repo.maven.apache.org/maven2/):
Connection reset -> [Help 1]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35430:
URL: https://github.com/apache/arrow/pull/35430#issuecomment-1537270292
Benchmark runs are scheduled for baseline = f0e14539dc546b53ed8614b128ed6df5e3b5feac and contender = 2c971511a1f59856b048416ea890743d382c0029. 2c971511a1f59856b048416ea890743d382c0029 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e7b361f482374d8985387e6ab3134853...4e4ebce837bf4b4f93cd7721e0aa9c14/)
[Failed :arrow_down:2.22% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d7ac118a4a7c4d2189d3fab48775a12a...f2ed96966f9343c3b05240c8370977cd/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8e57f70c53f04e07a4fdd5f13bbcd6fe...ebf3b01026794b3faf8f9442e4c62fcd/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/7234d59b5e2a438d9e2b6e4b5bf6dfea...2daac6974de949ed9a20f5788b0ee418/)
Buildkite builds:
[Finished] [`2c971511` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2825)
[Failed] [`2c971511` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2862)
[Finished] [`2c971511` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2825)
[Failed] [`2c971511` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2852)
[Finished] [`f0e14539` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2824)
[Failed] [`f0e14539` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2861)
[Finished] [`f0e14539` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2824)
[Failed] [`f0e14539` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2851)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35430:
URL: https://github.com/apache/arrow/pull/35430#issuecomment-1537270315
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/d7ac118a4a7c4d2189d3fab48775a12a...f2ed96966f9343c3b05240c8370977cd/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35430:
URL: https://github.com/apache/arrow/pull/35430#issuecomment-1537540816
Revision: 996cd86726477fd337459b59dad2a97abc25fb18
Submitted crossbow builds: [ursacomputing/crossbow @ actions-84a73cd34d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-84a73cd34d)
|Task|Status|
|----|------|
|wheel-windows-cp310-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4909294837/jobs/8765620032)|
|wheel-windows-cp311-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4909294943/jobs/8765620417)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4909294760/jobs/8765620301)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4909294808/jobs/8765619914)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4909294898/jobs/8765620287)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35430:
URL: https://github.com/apache/arrow/pull/35430#issuecomment-1534336453
:warning: GitHub issue #35099 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sjperkins commented on a diff in pull request #35430: GH-35099: [CI][Packaging] Upgrade vcpkg to 2023.04.15 Release
Posted by "sjperkins (via GitHub)" <gi...@apache.org>.
sjperkins commented on code in PR #35430:
URL: https://github.com/apache/arrow/pull/35430#discussion_r1184764156
##########
ci/vcpkg/ports.patch:
##########
@@ -49,18 +49,5 @@ index 0000000000..a57ce0c22f
+ return v & ~(mask << (8 * n));
+-#endif
+ }
-+
++
+ static inline bool LeftShiftOverflows(uint8_t value, uint32_t shift) {
-diff --git a/scripts/cmake/vcpkg_find_acquire_program.cmake b/scripts/cmake/vcpkg_find_acquire_program.cmake
-index 4611af6..d11936f 100644
---- a/scripts/cmake/vcpkg_find_acquire_program.cmake
-+++ b/scripts/cmake/vcpkg_find_acquire_program.cmake
-@@ -239,7 +239,7 @@ function(vcpkg_find_acquire_program program)
- set(paths_to_search "${DOWNLOADS}/tools/python/${tool_subdirectory}")
- vcpkg_list(SET post_install_command "${CMAKE_COMMAND}" -E rm python310._pth)
- else()
-- set(program_name python3)
-+ set(program_name python)
- set(brew_package_name "python")
- set(apt_package_name "python3")
- endif()
Review Comment:
I'll submit crossbow builds once the initial CI checks complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org