You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@celeborn.apache.org by zh...@apache.org on 2023/01/31 08:30:56 UTC
[incubator-celeborn] 02/02: [CELEBORN-253][MINOR] Fix the wrongly resolve celeborn.ha.master.node.id issue if enable HA (#1188)
This is an automated email from the ASF dual-hosted git repository.
zhouky pushed a commit to branch branch-0.2
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git
commit ab224098a22e7a43f2819da984de87ed1a71013d
Author: Rex(Hui) An <an...@126.com>
AuthorDate: Tue Jan 31 15:39:58 2023 +0800
[CELEBORN-253][MINOR] Fix the wrongly resolve celeborn.ha.master.node.id issue if enable HA (#1188)
---
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala | 1 +
common/src/test/scala/org/apache/celeborn/common/CelebornConfSuite.scala | 1 +
2 files changed, 2 insertions(+)
diff --git a/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala b/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
index 64b28106..31827e42 100644
--- a/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
+++ b/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
@@ -576,6 +576,7 @@ class CelebornConf(loadDefaults: Boolean) extends Cloneable with Logging with Se
val nodeConfPrefix = extractPrefix(HA_MASTER_NODE_HOST.key, "<id>")
getAllWithPrefix(nodeConfPrefix)
.map(_._1)
+ .filterNot(_.equals("id"))
.map(k => extractPrefix(k, "."))
.distinct
}
diff --git a/common/src/test/scala/org/apache/celeborn/common/CelebornConfSuite.scala b/common/src/test/scala/org/apache/celeborn/common/CelebornConfSuite.scala
index 1be8f13d..90d7bf34 100644
--- a/common/src/test/scala/org/apache/celeborn/common/CelebornConfSuite.scala
+++ b/common/src/test/scala/org/apache/celeborn/common/CelebornConfSuite.scala
@@ -152,6 +152,7 @@ class CelebornConfSuite extends RssFunSuite {
test("extract masterNodeIds") {
val conf = new CelebornConf()
+ .set("celeborn.ha.master.node.id", "1")
.set("celeborn.ha.master.node.1.host", "clb-1")
.set("celeborn.ha.master.node.2.host", "clb-1")
.set("celeborn.ha.master.node.3.host", "clb-1")