You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kylebarron (via GitHub)" <gi...@apache.org> on 2024/01/24 04:59:02 UTC

[I] Removing a column from a `RecordBatch` drops schema metadata [arrow-rs]

kylebarron opened a new issue, #5327:
URL: https://github.com/apache/arrow-rs/issues/5327

   **Describe the bug**
   
   Calling `remove_column` on a `RecordBatch` object deletes any schema metadata.
   
   In https://github.com/apache/arrow-rs/blob/a0148ba4cea1756bd22c534dff14e362cb5ee242/arrow-array/src/record_batch.rs#L357-L362
   
   
   It creates the new `SchemaBuilder` exclusively from the fields which calls this `From impl`
   
   https://github.com/apache/arrow-rs/blob/a0148ba4cea1756bd22c534dff14e362cb5ee242/arrow-schema/src/schema.rs#L125-L132
   
   instead of also taking into account the schema metadata.
   
   **To Reproduce**
   
   I don't have a full repro example but can create one if needed.
   <!--
   Steps to reproduce the behavior:
   -->
   
   **Expected behavior**
   
   Schema metadata not to be dropped
   <!--
   A clear and concise description of what you expected to happen.
   -->
   
   **Additional context**
   <!--
   Add any other context about the problem here.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Removing a column from a `RecordBatch` drops schema metadata [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #5327: Removing a column from a `RecordBatch` drops schema metadata
URL: https://github.com/apache/arrow-rs/issues/5327


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Removing a column from a `RecordBatch` drops schema metadata [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #5327:
URL: https://github.com/apache/arrow-rs/issues/5327#issuecomment-1972589360

   `label_issue.py` automatically added labels {'arrow'} from #5328


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org