You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tephra.apache.org by poornachandra <gi...@git.apache.org> on 2016/09/09 09:32:57 UTC
[GitHub] incubator-tephra pull request #9: Wait for Transaction Service to announce i...
GitHub user poornachandra opened a pull request:
https://github.com/apache/incubator-tephra/pull/9
Wait for Transaction Service to announce itself to fix flaky tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/poornachandra/incubator-tephra feature/fix-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tephra/pull/9.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9
----
commit 8f2cd72dbb59865c4edd4f2ff7ae9ccf96895bc3
Author: poorna <po...@cask.co>
Date: 2016-09-09T09:26:00Z
Adding HBase dependencies back to tephra-examples pom for IDE
commit c4c74e98704b770b6f5d5806839acec4089aeccf
Author: poorna <po...@cask.co>
Date: 2016-09-09T09:31:12Z
Wait for Transaction Service to announce itself to fix flaky tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tephra pull request #9: Wait for Transaction Service to announce i...
Posted by poornachandra <gi...@git.apache.org>.
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/9#discussion_r78230869
--- Diff: tephra-core/src/test/java/org/apache/tephra/ThriftTransactionSystemTest.java ---
@@ -88,10 +89,14 @@ protected void configure() {
txClient = injector.getInstance(TransactionSystemClient.class);
try {
LOG.info("Starting transaction service");
+ storage.startAndWait();
--- End diff --
It was being stopped without being started, so for consistency I am starting it here. However, start on this object is a no-op.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tephra issue #9: Wait for Transaction Service to announce itself t...
Posted by anwar6953 <gi...@git.apache.org>.
Github user anwar6953 commented on the issue:
https://github.com/apache/incubator-tephra/pull/9
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tephra pull request #9: Wait for Transaction Service to announce i...
Posted by poornachandra <gi...@git.apache.org>.
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/9#discussion_r78230677
--- Diff: tephra-examples/pom.xml ---
@@ -51,6 +55,53 @@
<artifactId>tephra-core</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
--- End diff --
Adding HBase dependencies back to tephra-examples pom for IDE
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tephra pull request #9: Wait for Transaction Service to announce i...
Posted by anwar6953 <gi...@git.apache.org>.
Github user anwar6953 commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/9#discussion_r78227433
--- Diff: tephra-examples/pom.xml ---
@@ -51,6 +55,53 @@
<artifactId>tephra-core</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
--- End diff --
why were all the pom changes necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tephra pull request #9: Wait for Transaction Service to announce i...
Posted by anwar6953 <gi...@git.apache.org>.
Github user anwar6953 commented on a diff in the pull request:
https://github.com/apache/incubator-tephra/pull/9#discussion_r78227091
--- Diff: tephra-core/src/test/java/org/apache/tephra/ThriftTransactionSystemTest.java ---
@@ -88,10 +89,14 @@ protected void configure() {
txClient = injector.getInstance(TransactionSystemClient.class);
try {
LOG.info("Starting transaction service");
+ storage.startAndWait();
--- End diff --
why start this here, but not in other test cases (TransactionAdminTest, for instance)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tephra pull request #9: Wait for Transaction Service to announce i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tephra/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---