You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/06 12:07:02 UTC
[GitHub] [airflow] potiuk opened a new issue #12851: Find a way to inform our users about deprecated extras
potiuk opened a new issue #12851:
URL: https://github.com/apache/airflow/issues/12851
There are a number of extras being deprecated in 2.0. Those are marked with "remove in 2.1" comments in 2.0, however users might simply have no clue that this deprecation is happening.
We should find a way to inform users.
One of the ways might be a small apache-airflow-deprecated package that will be added automatically as dependencies if someone uses that extra - such package could be a special provider that could register itself in Airflow and print a warning message when Airflow is started. Then we would have to figure out how to uninstall it when not needed and the user installs airflow next time. and in Airflow 2.1 we could - rather than removing the extras - increase the version of this package as required and make it fail heard with an appropriate message.
Not ideal but maybe it's the way to do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-919113501
I am afraid we only have a chance to check which extras are used at the moment of installation. After `pip install` completes, the fact of using extras is not recorded anywhere I believe. The idea that I had initially about "deprecated-extra" provider, might be about the only way that makes sense (Actually I completely forgot about this idea, only recalled it now by reading it again).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-739497482
> Something like this sounds like a good idea. I wonder if we could make it show up in the UI - that's the only "sure fire" way to get it in front of users
Agree. Fortunately this is not something we desperately need to to do for 2.0.0. It can be easily added in 2.0.1 or beyond.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-937415897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-937678836
Actually now when I think about it - we could have SINGLE empty `apache-airflow-deprecated-extra` package relesed in PyPI - and at this one package to all deprecated extras.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-739497482
> Something like this sounds like a good idea. I wonder if we could make it show up in the UI - that's the only "sure fire" way to get it in front of users
Agree. Fortunately this is not something we desperately need to to do for 2.0. It can be easily added in 2.0.1 or beyond.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-937416195
A built-in way to handle extra deprecation could be a good feature addition to the packaging system though. Someone should raise it on discuss.python.org 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-919113501
I am afraid we only have a chance to check which extras are used at the moment of installation after `pip install` completes, the fact of using extras is not recorded anywhere I believe. The idea that I had initially about "deprecated-extra" provider, might be about the only way that makes sense (Actually I completely forgot about this idea, only recalled it now by reading it again).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-937682062
Is there a way to print a warning by PyPI at the moment such packge is installed (or even attempted to be installed) @uranusjr rather than by importlib introspection ? Or maybe we could simply start "failing" such installation (for example we could add `apache-airflow-deprecated-extra>1.0.0` but release only 1.0.0 in `PyPI` or something similar ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-938330899
> Is there a way to print a warning by PyPI at the moment such packge is installed
Unfortunately no. Well there's a way to show some warnings by publishing 1.0.0 and yanking it (IIRC pip emits a warning if you're installing a yanked version via `==`), but I'm not sure if the message would be clear or even understandable for users.
> Or maybe we could simply start "failing" such installation
That you can, but personally I'd rather just remove those extras (which would emit a warning on installation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-937678836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vikramkoka commented on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
vikramkoka commented on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-739606054
This seems like a really good idea. I would be in favor of a slow deprecation on this too, something in the order of 2.1 or so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-739497482
> Something like this sounds like a good idea. I wonder if we could make it show up in the UI - that's the only "sure fire" way to get it in front of users
Agree. Fortunately this is not something we desperately need to to do for 2.0.0. It can be easily added in 2.0.1 or beyond. And even we can decide to keep the extras as 'deprecated' beyond 2.1 if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-739494267
Something like this sounds like a good idea. I wonder if we could make it show up in the UI - that's the only "sure fire" way to get it in front of users
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-937415897
If the deprecated extras are merged into the main dependency list, they can simply be removed since unrecognised extras are automatically ignored (with a warning). But there's not a good way to express that deprecation if the extra is renamed.
One hack to this would be to introduce various empty `apache-airflow-deprecated-extra-foo` packages, and organise dependencies like this:
```python
foo = ["dependency"]
deprecated_foo = ["dependency", "apache-airflow-deprecated-extra-foo"]
```
And detect the presence of `apache-airflow-deprecated-extra-foo` at runtime (with `importlib.metadata`) to show the deprecation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-919072797
@uranusjr Any ideas here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-739493626
@kaxil @ashb @turbaszek @mik-laj WDYT ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #12851: Find a way to inform our users about deprecated extras
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #12851:
URL: https://github.com/apache/airflow/issues/12851#issuecomment-938343001
Sounds like adding a new feature to PIP for that is the best route we can take :P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org