You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by wo...@apache.org on 2007/09/06 08:35:10 UTC

svn commit: r573158 - /portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal/src/java/org/apache/jetspeed/decoration/DecorationFactoryImpl.java

Author: woonsan
Date: Wed Sep  5 23:35:09 2007
New Revision: 573158

URL: http://svn.apache.org/viewvc?rev=573158&view=rev
Log:
Fixed a bug originated from the revision 551861, which was done for [JS2-739].
By the revision, o.a.j.u.Path#addSegment method does not change its object any more. Instead it returns newly created Path object.
However, o.a.j.decoration.DecorationFactoryImpl class has remained as it used to expect basePath to change itself in createClientPath() method.
Therefore, DecorationFactoryImpl#createClientPath() has to reset basePath variable by the returned new Path object.

Modified:
    portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal/src/java/org/apache/jetspeed/decoration/DecorationFactoryImpl.java

Modified: portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal/src/java/org/apache/jetspeed/decoration/DecorationFactoryImpl.java
URL: http://svn.apache.org/viewvc/portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal/src/java/org/apache/jetspeed/decoration/DecorationFactoryImpl.java?rev=573158&r1=573157&r2=573158&view=diff
==============================================================================
--- portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal/src/java/org/apache/jetspeed/decoration/DecorationFactoryImpl.java (original)
+++ portals/jetspeed-2/branches/JETSPEED-2.1.3/components/portal/src/java/org/apache/jetspeed/decoration/DecorationFactoryImpl.java Wed Sep  5 23:35:09 2007
@@ -342,16 +342,16 @@
         String country = locale.getCountry();
         String variant = locale.getVariant();
 
-        basePath.addSegment( mediaType ).addSegment( language );
+        basePath = basePath.addSegment( mediaType ).addSegment( language );
 
         if ( country != null )
         {
-            basePath.addSegment( country );
+            basePath = basePath.addSegment( country );
         }
 
         if (variant != null)
         {
-            basePath.addSegment( variant );
+            basePath = basePath.addSegment( variant );
         }
         return basePath;
     }



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org