You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/03/24 22:47:56 UTC

Review Request 32454: Fixed flaky MesosContainerizerDestroyTest tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32454/
-----------------------------------------------------------

Review request for mesos and Ian Downes.


Bugs: MESOS-2402
    https://issues.apache.org/jira/browse/MESOS-2402


Repository: mesos


Description
-------

See the ticket for details.


Diffs
-----

  src/tests/containerizer_tests.cpp 565903b754bbf5891891b183a283aee038eb1b8f 

Diff: https://reviews.apache.org/r/32454/diff/


Testing
-------

make check repeatedly.


Thanks,

Vinod Kone


Re: Review Request 32454: Fixed flaky MesosContainerizerDestroyTest tests.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32454/#review77673
-----------------------------------------------------------


Patch looks great!

Reviews applied: [32454]

All tests passed.

- Mesos ReviewBot


On March 24, 2015, 9:47 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32454/
> -----------------------------------------------------------
> 
> (Updated March 24, 2015, 9:47 p.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-2402
>     https://issues.apache.org/jira/browse/MESOS-2402
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See the ticket for details.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer_tests.cpp 565903b754bbf5891891b183a283aee038eb1b8f 
> 
> Diff: https://reviews.apache.org/r/32454/diff/
> 
> 
> Testing
> -------
> 
> make check repeatedly.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 32454: Fixed flaky MesosContainerizerDestroyTest tests.

Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32454/#review77682
-----------------------------------------------------------

Ship it!



src/tests/containerizer_tests.cpp
<https://reviews.apache.org/r/32454/#comment125870>

    kill the extra ;


- Ian Downes


On March 24, 2015, 2:47 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32454/
> -----------------------------------------------------------
> 
> (Updated March 24, 2015, 2:47 p.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-2402
>     https://issues.apache.org/jira/browse/MESOS-2402
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See the ticket for details.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer_tests.cpp 565903b754bbf5891891b183a283aee038eb1b8f 
> 
> Diff: https://reviews.apache.org/r/32454/diff/
> 
> 
> Testing
> -------
> 
> make check repeatedly.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>