You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2014/10/03 02:26:42 UTC
Review Request 26303: Move Mesos version from mesos.hpp to
version.hpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26303/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Repository: mesos-git
Description
-------
This allows the Module subsystem to simply include <mesos/version.hpp> instead of inheriting the whole protobuf header chain.
Diffs
-----
configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567
include/mesos/mesos.hpp.in 8aedf8c4d27014c3e61eac801d6267b3d316b38a
include/mesos/version.hpp.in PRE-CREATION
src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b
Diff: https://reviews.apache.org/r/26303/diff/
Testing
-------
make check
Thanks,
Kapil Arya
Re: Review Request 26303: Move Mesos version from mesos.hpp to
version.hpp.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26303/#review55308
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26303]
All tests passed.
- Mesos ReviewBot
On Oct. 3, 2014, 12:26 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26303/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 12:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This allows the Module subsystem to simply include <mesos/version.hpp> instead of inheriting the whole protobuf header chain.
>
>
> Diffs
> -----
>
> configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567
> include/mesos/mesos.hpp.in 8aedf8c4d27014c3e61eac801d6267b3d316b38a
> include/mesos/version.hpp.in PRE-CREATION
> src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b
>
> Diff: https://reviews.apache.org/r/26303/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 26303: Move Mesos version from mesos.hpp to
version.hpp.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26303/#review55305
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Oct. 2, 2014, 5:26 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26303/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 5:26 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This allows the Module subsystem to simply include <mesos/version.hpp> instead of inheriting the whole protobuf header chain.
>
>
> Diffs
> -----
>
> configure.ac 86d448c3ad00ad01d3d069c1039dc7ad524af567
> include/mesos/mesos.hpp.in 8aedf8c4d27014c3e61eac801d6267b3d316b38a
> include/mesos/version.hpp.in PRE-CREATION
> src/Makefile.am 27c42dfde45a449750132e416b4eaf776f8c5e3b
>
> Diff: https://reviews.apache.org/r/26303/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kapil Arya
>
>