You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sumitagrawl (via GitHub)" <gi...@apache.org> on 2024/07/26 11:00:30 UTC
[PR] HDDS-11195. state machine fail configuration for critical/non-critical operation [ozone]
sumitagrawl opened a new pull request, #6993:
URL: https://github.com/apache/ozone/pull/6993
## What changes were proposed in this pull request?
configuring request type that will be treated as non-critical and those failure should not cause termination of ozone state machine.
Configuration added: `ozone.om.requests.ignore.terminate.on.failure`
Default value: DeleteOpenKeys,EchoRPC
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11195
## How was this patch tested?
- unit test cases added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11195. state machine fail configuration for critical/non-critical operation [ozone]
Posted by "sumitagrawl (via GitHub)" <gi...@apache.org>.
sumitagrawl closed pull request #6993: HDDS-11195. state machine fail configuration for critical/non-critical operation
URL: https://github.com/apache/ozone/pull/6993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11195. state machine fail configuration for critical/non-critical operation [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #6993:
URL: https://github.com/apache/ozone/pull/6993#discussion_r1695210909
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerStateMachine.java:
##########
@@ -642,4 +655,13 @@ public void awaitDoubleBufferFlush() throws InterruptedException {
public OzoneManagerDoubleBuffer getOzoneManagerDoubleBuffer() {
return ozoneManagerDoubleBuffer;
}
+
+ private Set<String> getSplitRequestIgnoreFailure() {
Review Comment:
Something like this could be more readable?
```java
boolean canRequestFailureBeIgnored(RequestType type)
```
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -4429,4 +4429,13 @@
maximum number of buckets across all volumes.
</description>
</property>
+ <property>
+ <name>ozone.om.requests.ignore.terminate.on.failure</name>
+ <value>DeleteOpenKeys,EchoRPC</value>
Review Comment:
DeleteOpenKeys alters the openKeyTable cache inside the request. I feel any request that alters the state of OM (say cache/DB) should not come under this category as ignoring such failures might cause inconsistency in OM metadata
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -4429,4 +4429,13 @@
maximum number of buckets across all volumes.
</description>
</property>
+ <property>
+ <name>ozone.om.requests.ignore.terminate.on.failure</name>
Review Comment:
Should we provide this as a config or use it as a constant in code itself. Misuse of this property could be dangerous and lead to consistent state. By providing a config, the user/admin has control over internal behaviour of OM. IMO we should not provide such a config as providing such options will be more prone to problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11195. state machine fail configuration for critical/non-critical operation [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #6993:
URL: https://github.com/apache/ozone/pull/6993#discussion_r1695224555
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -4429,4 +4429,13 @@
maximum number of buckets across all volumes.
</description>
</property>
+ <property>
+ <name>ozone.om.requests.ignore.terminate.on.failure</name>
Review Comment:
Should we provide this as a config or use it as a constant in code itself. Misuse of this property could be dangerous and lead to inconsistent state. By providing a config, the user/admin has control over internal behaviour of OM. IMO we should not provide such a config as providing such options will be more prone to problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org