You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/01 05:33:41 UTC
[kudu-CR] [clock] modernize clock-related classes
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14330
Change subject: [clock] modernize clock-related classes
......................................................................
[clock] modernize clock-related classes
This patch updates the signature of clock-related classes to
appropriate C++11 keywords instead of macro.
This changelist doesn't contain any functional changes.
Change-Id: I476a55189d4131d7a749db22dcf6f8b2af25b521
---
M src/kudu/clock/clock.h
M src/kudu/clock/hybrid_clock-test.cc
M src/kudu/clock/hybrid_clock.h
M src/kudu/clock/logical_clock.h
M src/kudu/clock/system_ntp.h
M src/kudu/clock/system_unsync_time.h
6 files changed, 39 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/14330/1
--
To view, visit http://gerrit.cloudera.org:8080/14330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I476a55189d4131d7a749db22dcf6f8b2af25b521
Gerrit-Change-Number: 14330
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [clock] modernize clock-related classes
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [clock] modernize clock-related classes
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I476a55189d4131d7a749db22dcf6f8b2af25b521
Gerrit-Change-Number: 14330
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [clock] modernize clock-related classes
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14330 )
Change subject: [clock] modernize clock-related classes
......................................................................
Patch Set 1: Verified+1
Unrelated flake while building (the machine was rebooted?):
22:45:04 raise ProtocolError('Connection broken: %r' % e, e)
22:45:04 pip._vendor.urllib3.exceptions.ProtocolError: ("Connection broken: ConnectionResetError(104, 'Connection reset by peer')", ConnectionResetError(104, 'Connection reset by peer'))
--
To view, visit http://gerrit.cloudera.org:8080/14330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I476a55189d4131d7a749db22dcf6f8b2af25b521
Gerrit-Change-Number: 14330
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Oct 2019 05:59:30 +0000
Gerrit-HasComments: No
[kudu-CR] [clock] modernize clock-related classes
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14330 )
Change subject: [clock] modernize clock-related classes
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I476a55189d4131d7a749db22dcf6f8b2af25b521
Gerrit-Change-Number: 14330
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 01 Oct 2019 06:07:53 +0000
Gerrit-HasComments: No
[kudu-CR] [clock] modernize clock-related classes
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14330 )
Change subject: [clock] modernize clock-related classes
......................................................................
[clock] modernize clock-related classes
This patch updates the signature of clock-related classes to
appropriate C++11 keywords instead of macro.
This changelist doesn't contain any functional changes.
Change-Id: I476a55189d4131d7a749db22dcf6f8b2af25b521
Reviewed-on: http://gerrit.cloudera.org:8080/14330
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/clock/clock.h
M src/kudu/clock/hybrid_clock-test.cc
M src/kudu/clock/hybrid_clock.h
M src/kudu/clock/logical_clock.h
M src/kudu/clock/system_ntp.h
M src/kudu/clock/system_unsync_time.h
6 files changed, 39 insertions(+), 40 deletions(-)
Approvals:
Alexey Serbin: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14330
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I476a55189d4131d7a749db22dcf6f8b2af25b521
Gerrit-Change-Number: 14330
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)