[jira] [Commented] (FLINK-7652) Port CurrentJobIdsHandler to new REST endpoint

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182466#comment-16182466 ] 

ASF GitHub Bot commented on FLINK-7652:
---------------------------------------

GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/4734

    [FLINK-7652] [flip6] Port CurrentJobIdsHandler to new REST endpoint

    ## What is the purpose of the change
    
    This PR ports the existing `CurrentJobIdsHandler` to the new REST endpoint. The existing class `JobsWithIdsOverview` is reused as the response message (second commit renames the class to `JobStatusesWithIdsOverview`). Introduced `CurrentJobIdsHeaders` as part of the porting.
    
    This PR also includes a fix that the previous response message only contained job ids for statuses `RUNNING`, `FAILED`, `FINISHED`, and `CANCELLED`, whereas there are actually more statuses to differentiate, such as `CREATED`, `RESTARTING`, `SUSPENDED`, etc.
    
    ## Brief change log
    
    - Let `CurrentJobIdsHandler` implement the `LegacyRestHandler` interface
    - Introduced `CurrentJobIdsHeaders`
    - Added new methods to `DispatcherGateway` and `JobMasterGateway` to facilitate the porting
    - Register handler at `DispatcherRestEndpoint`
    - Reuse `JobsWithIdsOverview` class as response message (renamed to `JobStatusesWithIdsOverview`)
    - Let response message differentiate between all possible `JobStatus`.
    
    ## Verifying this change
    
    This change is already covered by existing tests.
    
    A new `JobStatusesWithIdsOverviewTest` is added to test the message marshalling.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? n/a
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink portCurrentJobIdsHandler

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4734.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4734
    
----
commit 4f3ad7a5d6566e23bb5138b0115e0863cb445a67
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
Date:   2017-09-27T11:02:32Z

    [FLINK-7652] [flip6] Port CurrentJobIdsHandler to new REST endpoint

commit c8653b1cf78a2695db757b5c9a89b1125c74f1ea
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
Date:   2017-09-27T11:20:07Z

    [FLINK-7652] [flip6] Rename JobsWithIdsOverview message class name
    
    Renamed to JobsStatusesWithIdsOverview, to better respresent the
    information that the message holds.

commit 662fe9cb64849b8af7758f9facaaa1dc65e6fb93
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
Date:   2017-09-27T12:09:43Z

    [FLINK-7652] [flip6] Let JobStatusesWithIdsOverview differentiate between all possible JobStatuses
    
    Prior to this commit, the JobStatusesWithIdsOverview only differentiates
    between RUNNING, FAILED, CANCELLED, and FINISHED. This commit fixes that
    to cover all possible JobStatus, including CREATED, CANCELLING, FAILING,
    RESTARTING, SUSPENDED, and RECONCILING.

----


> Port CurrentJobIdsHandler to new REST endpoint
> ----------------------------------------------
>
>                 Key: FLINK-7652
>                 URL: https://issues.apache.org/jira/browse/FLINK-7652
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST, Webfrontend
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>              Labels: flip-6
>             Fix For: 1.4.0
>
>
> Port existing {{CurrentJobIdsHandler}} to new REST endpoint



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)