You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/06 00:53:02 UTC
[GitHub] [arrow] kszucs opened a new pull request #10659: ARROW-12122: [Python] Cannot install via pip. M1 mac [WIP]
kszucs opened a new pull request #10659:
URL: https://github.com/apache/arrow/pull/10659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-882741326
@github-actions crossbow submit wheel-macos-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879324273
Revision: 086b4582939f4aef8b5784ab45ba4276f438ed6d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-590](https://github.com/ursacomputing/crossbow/branches/all?query=actions-590)
|Task|Status|
|----|------|
|wheel-manylinux2010-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-590-github-wheel-manylinux2010-cp36-amd64)|
|wheel-manylinux2010-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-590-github-wheel-manylinux2010-cp37-amd64)|
|wheel-manylinux2010-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-590-github-wheel-manylinux2010-cp38-amd64)|
|wheel-manylinux2010-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-590-github-wheel-manylinux2010-cp39-amd64)|
|wheel-manylinux2014-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-590-github-wheel-manylinux2014-cp36-amd64)|
|wheel-manylinux2014-cp36-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-590-github-wheel-manylinux2014-cp37-amd64)|
|wheel-manylinux2014-cp37-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-590-github-wheel-manylinux2014-cp38-amd64)|
|wheel-manylinux2014-cp38-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-590-github-wheel-manylinux2014-cp39-amd64)|
|wheel-manylinux2014-cp39-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs edited a comment on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs edited a comment on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879399202
@kou Interestingly we have [linker errors](https://github.com/ursacomputing/crossbow/runs/3060717856?check_suite_focus=true#step:8:654) in the universal2 build but the tests seem to work for both x86_64 and arm64 in their own seperate virtualenvs. Can this cause issues with `PARQUET_REQUIRE_ENCRYPTION` and `ARROW_S3` (`ARROW_FLIGHT` is disabled)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-12122: [Python] Cannot install via pip. M1 mac [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r664173518
##########
File path: wheel.sh
##########
@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+arrow_dir=$1
+build_dir=$2
+
+export ARROW_FLIGHT=OFF
+export ARROW_JEMALLOC=OFF
+export ARROW_SIMD_LEVEL=NONE
+export BUILD_PREFIX=$build_dir
+export CONFIG_PATH=/dev/null
+export MACOSX_DEPLOYMENT_TARGET=11.0
+export MB_PYTHON_VERSION=3.9
+export PLAT=arm64
Review comment:
The produced wheel has universal2 platform tag, though my original plan is to provide a pure arm64 wheel in the first iteration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip. M1 mac [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-874386746
https://issues.apache.org/jira/browse/ARROW-12122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r669029564
##########
File path: dev/tasks/python-wheels/github.linux.amd64.yml
##########
@@ -47,7 +47,7 @@ jobs:
{{ macros.github_upload_releases("arrow/python/repaired_wheels/*.whl")|indent }}
{{ macros.github_upload_gemfury("arrow/python/repaired_wheels/*.whl")|indent }}
- {% if arrow.branch == 'master' %}
+ {% if arrow.branch == 'm1' %}
Review comment:
Need to revert.
##########
File path: dev/tasks/python-wheels/travis.linux.arm64.yml
##########
@@ -66,7 +66,7 @@ after_success:
{{ macros.travis_upload_releases("arrow/python/repaired_wheels/*.whl") }}
{{ macros.travis_upload_gemfury("arrow/python/repaired_wheels/*.whl") }}
- {% if arrow.branch == 'master' %}
+ {% if arrow.branch == 'm1' %}
Review comment:
Need to revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879407362
Revision: 10dbf02030fc431bf175826a51214e643a916042
Submitted crossbow builds: [ursacomputing/crossbow @ actions-593](https://github.com/ursacomputing/crossbow/branches/all?query=actions-593)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-big-sur-cp39-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-macos-big-sur-cp39-universal2)|
|wheel-macos-high-sierra-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-macos-high-sierra-cp36-amd64)|
|wheel-macos-high-sierra-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-macos-high-sierra-cp37-amd64)|
|wheel-macos-high-sierra-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-macos-high-sierra-cp38-amd64)|
|wheel-macos-high-sierra-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-macos-high-sierra-cp39-amd64)|
|wheel-macos-mavericks-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-macos-mavericks-cp36-amd64)|
|wheel-macos-mavericks-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-macos-mavericks-cp37-amd64)|
|wheel-macos-mavericks-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-macos-mavericks-cp38-amd64)|
|wheel-macos-mavericks-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-macos-mavericks-cp39-amd64)|
|wheel-manylinux2010-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-manylinux2010-cp36-amd64)|
|wheel-manylinux2010-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-manylinux2010-cp37-amd64)|
|wheel-manylinux2010-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-manylinux2010-cp38-amd64)|
|wheel-manylinux2010-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-manylinux2010-cp39-amd64)|
|wheel-manylinux2014-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-manylinux2014-cp36-amd64)|
|wheel-manylinux2014-cp36-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-manylinux2014-cp37-amd64)|
|wheel-manylinux2014-cp37-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-manylinux2014-cp38-amd64)|
|wheel-manylinux2014-cp38-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-manylinux2014-cp39-amd64)|
|wheel-manylinux2014-cp39-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-windows-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-windows-cp36-amd64)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-windows-cp37-amd64)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-windows-cp38-amd64)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-593-github-wheel-windows-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r672328515
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1
ARROW_LZ4_BUILD_VERSION=v1.9.3
# mimalloc 1.6.7 didn't build on Visual Studio 2015
# https://github.com/microsoft/mimalloc/issues/353
-ARROW_MIMALLOC_BUILD_VERSION=v1.6.4
+ARROW_MIMALLOC_BUILD_VERSION=v1.7.2
Review comment:
@lidavidm how can I verify that https://github.com/apache/arrow/pull/10024 doesn't apply here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-12122: [Python] Cannot install via pip. M1 mac [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r664172803
##########
File path: wheel.sh
##########
@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+arrow_dir=$1
+build_dir=$2
+
+export ARROW_FLIGHT=OFF
+export ARROW_JEMALLOC=OFF
+export ARROW_SIMD_LEVEL=NONE
+export BUILD_PREFIX=$build_dir
Review comment:
If we don't set `BUILD_PREFIX` to a non-existing location then [multibuild will set it to /usr/local](https://github.com/matthew-brett/multibuild/blob/devel/configure_build.sh#L71-L80) causing a pretty misleading cmake issue.
CMake tries to locate numpy's include path [by importing it](https://github.com/Kitware/CMake/blob/v3.19.2/Modules/FindPython/Support.cmake#L3075) swallowing any errors. If `BUILD_PREFIX` is set to `/usr/local` then multibuild will prepend `PATH` by `/usr/local/bin` which is brew's `x86_64` installation prefix. This causes the shell script to call the `x86_64` variant of `cmake` instead of the `arm64` one under `/opt/homebrew/bin` which calls the universal2 python binary as `x86_64` where importing an `arm64` compiled numpy will fail, but silently, making CMake unable to locate numpy for both compiling libarrow_python and pyarrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r672332383
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1
ARROW_LZ4_BUILD_VERSION=v1.9.3
# mimalloc 1.6.7 didn't build on Visual Studio 2015
# https://github.com/microsoft/mimalloc/issues/353
-ARROW_MIMALLOC_BUILD_VERSION=v1.6.4
+ARROW_MIMALLOC_BUILD_VERSION=v1.7.2
Review comment:
As far as I can see that should only apply to 2.0.0 and 1.7.x should be safe (the commenter in https://github.com/microsoft/mimalloc/issues/363 claims 1.7.0 doesn't affect them at least)
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1
ARROW_LZ4_BUILD_VERSION=v1.9.3
# mimalloc 1.6.7 didn't build on Visual Studio 2015
# https://github.com/microsoft/mimalloc/issues/353
-ARROW_MIMALLOC_BUILD_VERSION=v1.6.4
+ARROW_MIMALLOC_BUILD_VERSION=v1.7.2
Review comment:
And the problematic test is still there - so assuming tests pass we should be OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-880735154
@github-actions crossbow submit wheel-macos-big-sur-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-880010837
@wesm @xhochy could you please verify locally the produced wheels?
- [pyarrow-5.0.0.dev471-cp39-cp39-macosx_11_0_arm64.whl](https://github.com/ursacomputing/crossbow/releases/download/actions-601-github-wheel-macos-big-sur-cp39-arm64/pyarrow-5.0.0.dev471-cp39-cp39-macosx_11_0_arm64.whl)
- [pyarrow-5.0.0.dev471-cp39-cp39-macosx_11_0_universal2.whl](https://github.com/ursacomputing/crossbow/releases/download/actions-601-github-wheel-macos-big-sur-cp39-universal2/pyarrow-5.0.0.dev471-cp39-cp39-macosx_11_0_universal2.whl)
There is an universal2 installer for Python 3.9: https://www.python.org/ftp/python/3.9.6/python-3.9.6-macos11.pkg, can be installed using:
```bash
arrow/ci/scripts/install_python.sh macos 3.9
```
Verify the `arm64` wheel:
```bash
rm -rf arrow/python/dist
export ARROW_FLIGHT=OFF
wget -P arrow/python/dist https://github.com/ursacomputing/crossbow/releases/download/actions-601-github-wheel-macos-big-sur-cp39-arm64/pyarrow-5.0.0.dev471-cp39-cp39-macosx_11_0_arm64.whl
arch -arm64 arrow/ci/scripts/python_wheel_macos_test.sh
```
Verify the `universal2` wheel:
```bash
rm -rf arrow/python/dist
export ARROW_FLIGHT=OFF
wget -P arrow/python/dist https://github.com/ursacomputing/crossbow/releases/download/actions-601-github-wheel-macos-big-sur-cp39-universal2/pyarrow-5.0.0.dev471-cp39-cp39-macosx_11_0_universal2.whl
arch -arm64 arrow/ci/scripts/python_wheel_macos_test.sh
arch -x86_64 arrow/ci/scripts/python_wheel_macos_test.sh
```
(have not tested the snippets, the paths might be wrong, but the test script looks for wheels under `arrow/python/dist`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-12122: [Python] Cannot install via pip. M1 mac [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r664171185
##########
File path: cpp/cmake_modules/FindSnappyAlt.cmake
##########
@@ -0,0 +1,117 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set(find_package_args)
Review comment:
Actually this snappy change wasn't required after using `CMAKE_APPLE_SILICON_PROCESSOR`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r672332383
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1
ARROW_LZ4_BUILD_VERSION=v1.9.3
# mimalloc 1.6.7 didn't build on Visual Studio 2015
# https://github.com/microsoft/mimalloc/issues/353
-ARROW_MIMALLOC_BUILD_VERSION=v1.6.4
+ARROW_MIMALLOC_BUILD_VERSION=v1.7.2
Review comment:
As far as I can see that should only apply to 2.0.0 and 1.7.x should be safe (the commenter in https://github.com/microsoft/mimalloc/issues/363 claims 1.7.0 doesn't affect them at least)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-880735831
Revision: 526244a414531175c624b5c250c191d2d1fe0ff7
Submitted crossbow builds: [ursacomputing/crossbow @ actions-602](https://github.com/ursacomputing/crossbow/branches/all?query=actions-602)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-602-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-big-sur-cp39-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-602-github-wheel-macos-big-sur-cp39-universal2)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r668350294
##########
File path: ci/scripts/install_python.sh
##########
@@ -0,0 +1,72 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -e
+
+declare -A platforms
+platforms=([windows]=Windows
+ [macos]=MacOSX
+ [linux]=Linux)
+
+declare -A versions
+versions=([3.6]=3.6.8
+ [3.7]=3.7.9
+ [3.8]=3.8.9
+ [3.9]=3.9.6)
+
+if [ "$#" -ne 2 ]; then
+ echo "Usage: $0 <platform> <version>"
+ exit 1
+elif [[ -z ${platforms[$1]} ]]; then
+ echo "Unexpected platform: ${1}"
+ exit 1
+fi
+
+platform=${platforms[$1]}
+version=$2
+full_version=${versions[$2]}
+
+if [ $platform == "MacOSX" ]; then
Review comment:
```suggestion
if [ $platform = "MacOSX" ]; then
```
##########
File path: ci/scripts/install_python.sh
##########
@@ -0,0 +1,72 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -e
Review comment:
```suggestion
set -eu
```
##########
File path: python/requirements-wheel-build.txt
##########
@@ -1,6 +1,7 @@
cython>=0.29.11
numpy==1.16.6; python_version < "3.9" and platform_machine != "aarch64"
Review comment:
```suggestion
numpy==1.16.6; python_version < "3.9" and (platform_machine == "i686" or platform_machine == "x86_64")
```
##########
File path: cpp/cmake_modules/FindSnappyAlt.cmake
##########
@@ -0,0 +1,117 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set(find_package_args)
Review comment:
Do we revert this change before we merge this?
##########
File path: python/requirements-wheel-build.txt
##########
@@ -1,6 +1,7 @@
cython>=0.29.11
numpy==1.16.6; python_version < "3.9" and platform_machine != "aarch64"
-numpy==1.19.4; python_version >= "3.9" or platform_machine == "aarch64"
-pandas<1.1.0; python_version < "3.8"
Review comment:
Is this deletion intentional?
##########
File path: dev/tasks/python-wheels/github.osx.arm64.yml
##########
@@ -0,0 +1,128 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Prerequisits on the host:
+# - brew install bash bison coreutils ninja cmake
+# - sudo arrow/ci/scripts/install_python.sh macos 3.9
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+env:
+ ARROW_S3: {{ arrow_s3 }}
+ ARROW_FLIGHT: OFF
+ ARROW_JEMALLOC: OFF
+ ARROW_SIMD_LEVEL: NONE
+ CC: "clang"
+ CMAKE_CXX_COMPILER_LAUNCHER: "ccache"
Review comment:
Do we need this?
I think that our CMake configuration detects ccache automatically.
##########
File path: ci/scripts/python_wheel_macos_build.sh
##########
@@ -31,11 +31,24 @@ rm -rf ${source_dir}/python/repaired_wheels
rm -rf ${source_dir}/python/pyarrow/*.so
rm -rf ${source_dir}/python/pyarrow/*.so.*
-echo "=== (${PYTHON_VERSION}) Set OSX SDK and C flags ==="
-# Arrow is 64-bit-only at the moment
-export CFLAGS="-fPIC -arch x86_64 ${CFLAGS//-arch i386/}"
-export CXXFLAGS="-fPIC -arch x86_64 ${CXXFLAGS//-arch i386} -std=c++11"
-export SDKROOT="$(xcrun --show-sdk-path)"
+echo "=== (${PYTHON_VERSION}) Set SDK, C++ and Wheel flags ==="
+export SDKROOT=${SDKROOT:-$(xcrun --sdk macosx --show-sdk-path)}
+export MACOSX_DEPLOYMENT_TARGET=${MACOSX_DEPLOYMENT_TARGET:-10.9}
+if [ "$(uname -m)" = "arm64" ]; then
+ export CMAKE_APPLE_SILICON_PROCESSOR=arm64
+ export CFLAGS="-arch arm64"
+ export CXXFLAGS="-arch arm64"
+ export ARCHFLAGS="-arch arm64"
+ export _PYTHON_HOST_PLATFORM="macosx-${MACOSX_DEPLOYMENT_TARGET}-arm64"
+else
+ export CFLAGS="-arch x86_64"
+ export CXXFLAGS="-arch x86_64"
+ export ARCHFLAGS="-arch x86_64"
+ export _PYTHON_HOST_PLATFORM="macosx-${MACOSX_DEPLOYMENT_TARGET}-x86_64"
+fi
+
+echo "=== (${PYTHON_VERSION}) Install python build dependencies ==="
Review comment:
```suggestion
echo "=== (${PYTHON_VERSION}) Install Python build dependencies ==="
```
##########
File path: dev/tasks/python-wheels/github.osx.amd64.yml
##########
@@ -19,28 +19,29 @@
{{ macros.github_header() }}
env:
+ CC: "clang"
+ CXX: "clang++"
Review comment:
Could you keep this list in alphabetical order?
##########
File path: python/requirements-wheel-build.txt
##########
@@ -1,6 +1,7 @@
cython>=0.29.11
numpy==1.16.6; python_version < "3.9" and platform_machine != "aarch64"
-numpy==1.19.4; python_version >= "3.9" or platform_machine == "aarch64"
-pandas<1.1.0; python_version < "3.8"
+numpy==1.19.4; sys_platform != "darwin" and (python_version >= "3.9" or platform_machine == "aarch64")
+numpy==1.19.4; sys_platform == "darwin" and python_version >= "3.9" and platform_machine != "arm64"
+numpy==1.21.0; sys_platform == "darwin" and platform_machine == "arm64"
Review comment:
```suggestion
numpy==1.19.4; python_version >= "3.9" and platform_machine != "arm64"
numpy==1.21.0; platform_machine == "arm64"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879954701
Revision: 22c14e2dd8a41cd1195b60ebbe33eb358d5782b3
Submitted crossbow builds: [ursacomputing/crossbow @ actions-601](https://github.com/ursacomputing/crossbow/branches/all?query=actions-601)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-big-sur-cp39-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-macos-big-sur-cp39-universal2)|
|wheel-macos-high-sierra-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-macos-high-sierra-cp36-amd64)|
|wheel-macos-high-sierra-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-macos-high-sierra-cp37-amd64)|
|wheel-macos-high-sierra-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-macos-high-sierra-cp38-amd64)|
|wheel-macos-high-sierra-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-macos-high-sierra-cp39-amd64)|
|wheel-macos-mavericks-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-macos-mavericks-cp36-amd64)|
|wheel-macos-mavericks-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-macos-mavericks-cp37-amd64)|
|wheel-macos-mavericks-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-macos-mavericks-cp38-amd64)|
|wheel-macos-mavericks-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-macos-mavericks-cp39-amd64)|
|wheel-manylinux2010-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-manylinux2010-cp36-amd64)|
|wheel-manylinux2010-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-manylinux2010-cp37-amd64)|
|wheel-manylinux2010-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-manylinux2010-cp38-amd64)|
|wheel-manylinux2010-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-manylinux2010-cp39-amd64)|
|wheel-manylinux2014-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-manylinux2014-cp36-amd64)|
|wheel-manylinux2014-cp36-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-manylinux2014-cp37-amd64)|
|wheel-manylinux2014-cp37-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-manylinux2014-cp38-amd64)|
|wheel-manylinux2014-cp38-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-manylinux2014-cp39-amd64)|
|wheel-manylinux2014-cp39-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-windows-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-windows-cp36-amd64)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-windows-cp37-amd64)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-windows-cp38-amd64)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-601-github-wheel-windows-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879681273
> @kou Interestingly we have [linker errors](https://github.com/ursacomputing/crossbow/runs/3060717856?check_suite_focus=true#step:8:654) in the universal2 build but the tests seem to work for both x86_64 and arm64 in their own seperate virtualenvs.
These only seem to be warnings and not errors. Hard to determine if they really are problematic without seeing the full linker line as that could simply contain both static libraries. It would work if it is always ignoring one of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-12122: [Python] Cannot install via pip. M1 mac [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r664173327
##########
File path: ci/scripts/python_wheel_macos_build.sh
##########
@@ -62,14 +62,18 @@ echo "=== (${PYTHON_VERSION}) Building Arrow C++ libraries ==="
mkdir -p ${build_dir}/build
pushd ${build_dir}/build
+
cmake \
+ -DCMAKE_APPLE_SILICON_PROCESSOR=arm64 \
-DARROW_BUILD_SHARED=ON \
+ -DARROW_SIMD_LEVEL=${ARROW_SIMD_LEVEL} \
+ -DARROW_RUNTIME_SIMD_LEVEL=NONE \
Review comment:
Remove this during the cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-882711776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-878632291
@github-actions crossbow submit wheel-macos-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip. M1 mac [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-874386746
https://issues.apache.org/jira/browse/ARROW-12122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-12122: [Python] Cannot install via pip. M1 mac [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r664170931
##########
File path: ci/vcpkg/arm64-osx-static-release.cmake~
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set(VCPKG_TARGET_ARCHITECTURE x64)
Review comment:
Need to remove this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879273327
@github-actions crossbow submit -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879866046
> These only seem to be warnings and not errors. Hard to determine if they really are problematic without seeing the full linker line as that could simply contain both static libraries. It would work if it is always ignoring one of them.
@xhochy what do you mean under both libraries? The vcpkg dependencies are built as universal2 binaries. After inspecting the rest of the dependencies seems like libcrypto and libssl are the only ones built as arm64 only libraries:
```console
ursa-m1-mini:lib github$ file libz.a
libz.a: Mach-O universal binary with 2 architectures: [x86_64:current ar archive random library] [arm64:current ar archive random library]
libz.a (for architecture x86_64): current ar archive random library
libz.a (for architecture arm64): current ar archive random library
```
```console
ursa-m1-mini:lib github$ file libssl.a
libssl.a: current ar archive random library
ursa-m1-mini:lib github$ file libcrypto.a
libcrypto.a: current ar archive random library
```
If the linker just ignores these libraries then I assume that there should be missing symbols in the final libarrow binary, but the tests don't trigger such an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r668317077
##########
File path: ci/scripts/install_python.sh
##########
@@ -0,0 +1,72 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set -e
+
+declare -A platforms
+platforms=([windows]=Windows
+ [macos]=MacOSX
+ [linux]=Linux)
+
+declare -A versions
+versions=([3.6]=3.6.8
+ [3.7]=3.7.9
+ [3.8]=3.8.9
+ [3.9]=3.9.6)
Review comment:
Seems like there is no universal2 installers for python < 3.9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879323725
@github-actions crossbow submit wheel-manylinux*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-882711776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r672348467
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1
ARROW_LZ4_BUILD_VERSION=v1.9.3
# mimalloc 1.6.7 didn't build on Visual Studio 2015
# https://github.com/microsoft/mimalloc/issues/353
-ARROW_MIMALLOC_BUILD_VERSION=v1.6.4
+ARROW_MIMALLOC_BUILD_VERSION=v1.7.2
Review comment:
Thanks!
##########
File path: cpp/cmake_modules/FindSnappyAlt.cmake
##########
@@ -0,0 +1,117 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set(find_package_args)
Review comment:
Reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r672349594
##########
File path: dev/tasks/python-wheels/github.osx.arm64.yml
##########
@@ -0,0 +1,128 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Prerequisits on the host:
+# - brew install bash bison coreutils ninja cmake
+# - sudo arrow/ci/scripts/install_python.sh macos 3.9
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+env:
+ ARROW_S3: {{ arrow_s3 }}
+ ARROW_FLIGHT: OFF
+ ARROW_JEMALLOC: OFF
+ ARROW_SIMD_LEVEL: NONE
+ CC: "clang"
+ CMAKE_CXX_COMPILER_LAUNCHER: "ccache"
Review comment:
We need this to use ccache when compiling the vcpkg binaries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-882741834
Revision: bb3b170b2e204a1fdf85e94eda5332958bdddde4
Submitted crossbow builds: [ursacomputing/crossbow @ actions-614](https://github.com/ursacomputing/crossbow/branches/all?query=actions-614)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-614-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-big-sur-cp39-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-614-github-wheel-macos-big-sur-cp39-universal2)|
|wheel-macos-high-sierra-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-614-github-wheel-macos-high-sierra-cp36-amd64)|
|wheel-macos-high-sierra-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-614-github-wheel-macos-high-sierra-cp37-amd64)|
|wheel-macos-high-sierra-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-614-github-wheel-macos-high-sierra-cp38-amd64)|
|wheel-macos-high-sierra-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-614-github-wheel-macos-high-sierra-cp39-amd64)|
|wheel-macos-mavericks-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-614-github-wheel-macos-mavericks-cp36-amd64)|
|wheel-macos-mavericks-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-614-github-wheel-macos-mavericks-cp37-amd64)|
|wheel-macos-mavericks-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-614-github-wheel-macos-mavericks-cp38-amd64)|
|wheel-macos-mavericks-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-614-github-wheel-macos-mavericks-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r669685801
##########
File path: python/requirements-wheel-build.txt
##########
@@ -1,6 +1,11 @@
cython>=0.29.11
-numpy==1.16.6; python_version < "3.9" and platform_machine != "aarch64"
-numpy==1.19.4; python_version >= "3.9" or platform_machine == "aarch64"
-pandas<1.1.0; python_version < "3.8"
setuptools_scm
wheel
+numpy==1.19.4; platform_system == "Linux" and platform_machine == "aarch64"
+numpy==1.16.6; platform_system == "Linux" and platform_machine != "aarch64" and python_version < "3.9"
+numpy==1.19.4; platform_system == "Linux" and platform_machine != "aarch64" and python_version >= "3.9"
+numpy==1.21.0; platform_system == "Darwin" and platform_machine == "arm64"
+numpy==1.16.6; platform_system == "Darwin" and platform_machine != "arm64" and python_version < "3.8"
+numpy==1.19.4; platform_system == "Darwin" and platform_machine != "arm64" and python_version >= "3.8"
+numpy==1.16.6; platform_system == "Windows" and python_version < "3.9"
+numpy==1.19.4; platform_system == "Windows" and python_version >= "3.9"
Review comment:
I expanded the conditions so it's easier to handle platform specific cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs edited a comment on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs edited a comment on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879399202
@kou Interestingly we have [linker errors](https://github.com/ursacomputing/crossbow/runs/3060717856?check_suite_focus=true#step:8:654) in the universal2 build but the tests seem to work for both x86_64 and arm64 in their own seperate virtualenvs. Can this cause issues with `PARQUET_REQUIRE_ENCRYPTION` and `ARROW_S3` (`ARROW_FLIGHT` is disabled)?
cc @xhochy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-12122: [Python] Cannot install via pip. M1 mac [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r664170706
##########
File path: ci/scripts/python_wheel_macos_build.sh
##########
@@ -62,14 +62,18 @@ echo "=== (${PYTHON_VERSION}) Building Arrow C++ libraries ==="
mkdir -p ${build_dir}/build
pushd ${build_dir}/build
+
cmake \
+ -DCMAKE_APPLE_SILICON_PROCESSOR=arm64 \
Review comment:
We don't need to use the `CMAKE_SYSTEM_*` variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-882711776
@github-actions crossbow submit -g nightly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879364310
Revision: 086b4582939f4aef8b5784ab45ba4276f438ed6d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-591](https://github.com/ursacomputing/crossbow/branches/all?query=actions-591)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-big-sur-cp39-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-macos-big-sur-cp39-universal2)|
|wheel-macos-high-sierra-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-macos-high-sierra-cp36-amd64)|
|wheel-macos-high-sierra-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-macos-high-sierra-cp37-amd64)|
|wheel-macos-high-sierra-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-macos-high-sierra-cp38-amd64)|
|wheel-macos-high-sierra-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-macos-high-sierra-cp39-amd64)|
|wheel-macos-mavericks-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-macos-mavericks-cp36-amd64)|
|wheel-macos-mavericks-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-macos-mavericks-cp37-amd64)|
|wheel-macos-mavericks-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-macos-mavericks-cp38-amd64)|
|wheel-macos-mavericks-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-macos-mavericks-cp39-amd64)|
|wheel-manylinux2010-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-manylinux2010-cp36-amd64)|
|wheel-manylinux2010-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-manylinux2010-cp37-amd64)|
|wheel-manylinux2010-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-manylinux2010-cp38-amd64)|
|wheel-manylinux2010-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-manylinux2010-cp39-amd64)|
|wheel-manylinux2014-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-manylinux2014-cp36-amd64)|
|wheel-manylinux2014-cp36-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-manylinux2014-cp37-amd64)|
|wheel-manylinux2014-cp37-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-manylinux2014-cp38-amd64)|
|wheel-manylinux2014-cp38-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-manylinux2014-cp39-amd64)|
|wheel-manylinux2014-cp39-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-windows-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-windows-cp36-amd64)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-windows-cp37-amd64)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-windows-cp38-amd64)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-591-github-wheel-windows-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-878632724
Revision: 0f094730b1e9f3e49077a8d746668251e2bb8ddf
Submitted crossbow builds: [ursacomputing/crossbow @ actions-585](https://github.com/ursacomputing/crossbow/branches/all?query=actions-585)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-585-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-high-sierra-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-585-github-wheel-macos-high-sierra-cp36-amd64)|
|wheel-macos-high-sierra-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-585-github-wheel-macos-high-sierra-cp37-amd64)|
|wheel-macos-high-sierra-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-585-github-wheel-macos-high-sierra-cp38-amd64)|
|wheel-macos-high-sierra-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-585-github-wheel-macos-high-sierra-cp39-amd64)|
|wheel-macos-mavericks-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-585-github-wheel-macos-mavericks-cp36-amd64)|
|wheel-macos-mavericks-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-585-github-wheel-macos-mavericks-cp37-amd64)|
|wheel-macos-mavericks-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-585-github-wheel-macos-mavericks-cp38-amd64)|
|wheel-macos-mavericks-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-585-github-wheel-macos-mavericks-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879273832
Revision: 736739d28dcacc2256671660be0a6bbe8ed0008d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-588](https://github.com/ursacomputing/crossbow/branches/all?query=actions-588)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-big-sur-cp39-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-macos-big-sur-cp39-universal2)|
|wheel-macos-high-sierra-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-macos-high-sierra-cp36-amd64)|
|wheel-macos-high-sierra-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-macos-high-sierra-cp37-amd64)|
|wheel-macos-high-sierra-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-macos-high-sierra-cp38-amd64)|
|wheel-macos-high-sierra-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-macos-high-sierra-cp39-amd64)|
|wheel-macos-mavericks-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-macos-mavericks-cp36-amd64)|
|wheel-macos-mavericks-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-macos-mavericks-cp37-amd64)|
|wheel-macos-mavericks-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-macos-mavericks-cp38-amd64)|
|wheel-macos-mavericks-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-macos-mavericks-cp39-amd64)|
|wheel-manylinux2010-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-manylinux2010-cp36-amd64)|
|wheel-manylinux2010-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-manylinux2010-cp37-amd64)|
|wheel-manylinux2010-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-manylinux2010-cp38-amd64)|
|wheel-manylinux2010-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-manylinux2010-cp39-amd64)|
|wheel-manylinux2014-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-manylinux2014-cp36-amd64)|
|wheel-manylinux2014-cp36-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-manylinux2014-cp37-amd64)|
|wheel-manylinux2014-cp37-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-manylinux2014-cp38-amd64)|
|wheel-manylinux2014-cp38-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-manylinux2014-cp39-amd64)|
|wheel-manylinux2014-cp39-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-windows-cp36|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-windows-cp36)|
|wheel-windows-cp37|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-windows-cp37)|
|wheel-windows-cp38|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-windows-cp38)|
|wheel-windows-cp39|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-588-github-wheel-windows-cp39)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879406726
@github-actions crossbow submit -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879058098
Revision: af0f71743fce3a9b0e4ce648b1c861a4cbc3d079
Submitted crossbow builds: [ursacomputing/crossbow @ actions-587](https://github.com/ursacomputing/crossbow/branches/all?query=actions-587)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-high-sierra-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-macos-high-sierra-cp36-amd64)|
|wheel-macos-high-sierra-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-macos-high-sierra-cp37-amd64)|
|wheel-macos-high-sierra-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-macos-high-sierra-cp38-amd64)|
|wheel-macos-high-sierra-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-macos-high-sierra-cp39-amd64)|
|wheel-macos-mavericks-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-macos-mavericks-cp36-amd64)|
|wheel-macos-mavericks-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-macos-mavericks-cp37-amd64)|
|wheel-macos-mavericks-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-macos-mavericks-cp38-amd64)|
|wheel-macos-mavericks-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-macos-mavericks-cp39-amd64)|
|wheel-manylinux2010-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-manylinux2010-cp36-amd64)|
|wheel-manylinux2010-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-manylinux2010-cp37-amd64)|
|wheel-manylinux2010-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-manylinux2010-cp38-amd64)|
|wheel-manylinux2010-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-manylinux2010-cp39-amd64)|
|wheel-manylinux2014-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-manylinux2014-cp36-amd64)|
|wheel-manylinux2014-cp36-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-manylinux2014-cp37-amd64)|
|wheel-manylinux2014-cp37-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-manylinux2014-cp38-amd64)|
|wheel-manylinux2014-cp38-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-manylinux2014-cp39-amd64)|
|wheel-manylinux2014-cp39-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-windows-cp36|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-windows-cp36)|
|wheel-windows-cp37|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-windows-cp37)|
|wheel-windows-cp38|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-windows-cp38)|
|wheel-windows-cp39|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-587-github-wheel-windows-cp39)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879895354
@github-actions crossbow submit wheel-manylinux2014-cp36-arm64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r664614351
##########
File path: wheel.sh
##########
@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+arrow_dir=$1
Review comment:
Ideally we should put this script to a crossbow template building on an M1 machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs edited a comment on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs edited a comment on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879866046
> These only seem to be warnings and not errors. Hard to determine if they really are problematic without seeing the full linker line as that could simply contain both static libraries. It would work if it is always ignoring one of them.
@xhochy what do you mean under both libraries? The vcpkg dependencies are built as universal2 binaries. After inspecting the rest of the dependencies seems like libcrypto and libssl are the only ones built as arm64 only libraries:
```console
ursa-m1-mini:lib github$ file libz.a
libz.a: Mach-O universal binary with 2 architectures: [x86_64:current ar archive random library] [arm64:current ar archive random library]
libz.a (for architecture x86_64): current ar archive random library
libz.a (for architecture arm64): current ar archive random library
```
```console
ursa-m1-mini:lib github$ file libssl.a
libssl.a: current ar archive random library
ursa-m1-mini:lib github$ file libcrypto.a
libcrypto.a: current ar archive random library
```
```console
ursa-m1-mini:lib github$ lipo -info libz.a
Architectures in the fat file: libz.a are: x86_64 arm64
ursa-m1-mini:lib github$ lipo -info libssl.a
Non-fat file: libssl.a is architecture: arm64
```
If the linker just ignores these libraries then I assume that there should be missing symbols in the final libarrow binary, but the tests don't trigger such an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879954063
@github-actions crossbow submit -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-12122: [Python] Cannot install via pip. M1 mac [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r664170812
##########
File path: ci/scripts/python_wheel_macos_build.sh
##########
@@ -62,14 +62,18 @@ echo "=== (${PYTHON_VERSION}) Building Arrow C++ libraries ==="
mkdir -p ${build_dir}/build
pushd ${build_dir}/build
+
cmake \
+ -DCMAKE_APPLE_SILICON_PROCESSOR=arm64 \
-DARROW_BUILD_SHARED=ON \
+ -DARROW_SIMD_LEVEL=${ARROW_SIMD_LEVEL} \
+ -DARROW_RUNTIME_SIMD_LEVEL=NONE \
-DARROW_BUILD_STATIC=OFF \
-DARROW_BUILD_TESTS=OFF \
-DARROW_DATASET=${ARROW_DATASET} \
-DARROW_DEPENDENCY_SOURCE="VCPKG" \
-DARROW_DEPENDENCY_USE_SHARED=OFF \
- -DARROW_FLIGHT==${ARROW_FLIGHT} \
+ -DARROW_FLIGHT=${ARROW_FLIGHT} \
Review comment:
`gRPC` is not supported on apple silicon at the moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r664613850
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1
ARROW_LZ4_BUILD_VERSION=v1.9.3
# mimalloc 1.6.7 didn't build on Visual Studio 2015
# https://github.com/microsoft/mimalloc/issues/353
-ARROW_MIMALLOC_BUILD_VERSION=v1.6.4
+ARROW_MIMALLOC_BUILD_VERSION=v1.7.2
Review comment:
Need to check that it won't cause any performance regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879506199
It's strange...
Can we confirm which OpenSSL is used for this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-878640149
Revision: e1ab42b861b169217a02102c969c939f47695808
Submitted crossbow builds: [ursacomputing/crossbow @ actions-586](https://github.com/ursacomputing/crossbow/branches/all?query=actions-586)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-586-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-high-sierra-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-586-github-wheel-macos-high-sierra-cp36-amd64)|
|wheel-macos-high-sierra-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-586-github-wheel-macos-high-sierra-cp37-amd64)|
|wheel-macos-high-sierra-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-586-github-wheel-macos-high-sierra-cp38-amd64)|
|wheel-macos-high-sierra-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-586-github-wheel-macos-high-sierra-cp39-amd64)|
|wheel-macos-mavericks-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-586-github-wheel-macos-mavericks-cp36-amd64)|
|wheel-macos-mavericks-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-586-github-wheel-macos-mavericks-cp37-amd64)|
|wheel-macos-mavericks-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-586-github-wheel-macos-mavericks-cp38-amd64)|
|wheel-macos-mavericks-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-586-github-wheel-macos-mavericks-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #10659:
URL: https://github.com/apache/arrow/pull/10659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mdagost commented on pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
mdagost commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-894703287
Cool. I crated a JIRA: https://issues.apache.org/jira/browse/ARROW-13583
Snowflake is pretty popular, so I'm surprised nobody has asked yet. They're saying they can't/won't upgrade their pyarrow until the September timeframe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879399202
@kou Interestingly we have [linker errors](https://github.com/ursacomputing/crossbow/runs/3060717856?check_suite_focus=true#step:8:654) in the universal2 build but the tests seem to work for both x86_64 and arm64 in their own seperate virtualenvs. Can this cause issues with `PARQUET_REQUIRE_ENCRYPTION` and `ARROW_S3`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r672328515
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1
ARROW_LZ4_BUILD_VERSION=v1.9.3
# mimalloc 1.6.7 didn't build on Visual Studio 2015
# https://github.com/microsoft/mimalloc/issues/353
-ARROW_MIMALLOC_BUILD_VERSION=v1.6.4
+ARROW_MIMALLOC_BUILD_VERSION=v1.7.2
Review comment:
@lidavidm how can I verify that https://github.com/apache/arrow/pull/10024 doesn't apply here?
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1
ARROW_LZ4_BUILD_VERSION=v1.9.3
# mimalloc 1.6.7 didn't build on Visual Studio 2015
# https://github.com/microsoft/mimalloc/issues/353
-ARROW_MIMALLOC_BUILD_VERSION=v1.6.4
+ARROW_MIMALLOC_BUILD_VERSION=v1.7.2
Review comment:
Thanks!
##########
File path: cpp/cmake_modules/FindSnappyAlt.cmake
##########
@@ -0,0 +1,117 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set(find_package_args)
Review comment:
Reverted.
##########
File path: dev/tasks/python-wheels/github.osx.arm64.yml
##########
@@ -0,0 +1,128 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Prerequisits on the host:
+# - brew install bash bison coreutils ninja cmake
+# - sudo arrow/ci/scripts/install_python.sh macos 3.9
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+env:
+ ARROW_S3: {{ arrow_s3 }}
+ ARROW_FLIGHT: OFF
+ ARROW_JEMALLOC: OFF
+ ARROW_SIMD_LEVEL: NONE
+ CC: "clang"
+ CMAKE_CXX_COMPILER_LAUNCHER: "ccache"
Review comment:
We need this to use ccache when compiling the vcpkg binaries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879953917
@kou @xhochy seems like openssl [doesn't provide a build preset](https://github.com/openssl/openssl/blob/1c0eede9827b0962f1d752fa4ab5d436fa039da4/Configurations/10-main.conf#L1581) for universal2 macOS binaries yet, so setting `VCPKG_OSX_ARCHITECTURES` can't propagate the necessary settings to the OpenSSL build.
I managed to overcome the issue by [merging the arm64 and x86_64 static binaries manually using lipo](https://github.com/apache/arrow/pull/10659/files#diff-5be10d80211782bf839174974e27e5b2a964889513433244f6916e91df9802c9R69-R86).
Another option would be to use the [delocate-fuse](https://github.com/matthew-brett/delocate/blob/master/delocate/fuse.py) utility, but since the `VCPKG_OSX_ARCHITECTURES` approach works for the rest of the dependencies I chose to stick with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-12122: [Python] Cannot install via pip. M1 mac [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r664173698
##########
File path: wheel.sh
##########
@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+arrow_dir=$1
+build_dir=$2
+
+export ARROW_FLIGHT=OFF
+export ARROW_JEMALLOC=OFF
+export ARROW_SIMD_LEVEL=NONE
+export BUILD_PREFIX=$build_dir
+export CONFIG_PATH=/dev/null
+export MACOSX_DEPLOYMENT_TARGET=11.0
+export MB_PYTHON_VERSION=3.9
+export PLAT=arm64
Review comment:
Tried `export ARCHFLAGS=" -arch arm64"`, but still.
##########
File path: wheel.sh
##########
@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+arrow_dir=$1
+build_dir=$2
+
+export ARROW_FLIGHT=OFF
+export ARROW_JEMALLOC=OFF
+export ARROW_SIMD_LEVEL=NONE
+export BUILD_PREFIX=$build_dir
+export CONFIG_PATH=/dev/null
+export MACOSX_DEPLOYMENT_TARGET=11.0
+export MB_PYTHON_VERSION=3.9
+export PLAT=arm64
Review comment:
Tried to `export ARCHFLAGS=" -arch arm64"`, but still.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-882712592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r672332807
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1
ARROW_LZ4_BUILD_VERSION=v1.9.3
# mimalloc 1.6.7 didn't build on Visual Studio 2015
# https://github.com/microsoft/mimalloc/issues/353
-ARROW_MIMALLOC_BUILD_VERSION=v1.6.4
+ARROW_MIMALLOC_BUILD_VERSION=v1.7.2
Review comment:
And the problematic test is still there - so assuming tests pass we should be OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #10659:
URL: https://github.com/apache/arrow/pull/10659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-880753538
https://issues.apache.org/jira/browse/ARROW-10658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-894702741
I'm not sure since:
- we haven't received many requests to build M1 wheels for older arrow releases yet
- it would probably require more effort than it looks like at first glance
Either way, could you please create a JIRA ticket so we can track this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879895954
Revision: 46152ed9307544481a3ccb1530810db0212e3587
Submitted crossbow builds: [ursacomputing/crossbow @ actions-600](https://github.com/ursacomputing/crossbow/branches/all?query=actions-600)
|Task|Status|
|----|------|
|wheel-manylinux2014-cp36-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879056105
@github-actions crossbow submit -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879378962
Revision: 3aa0df229a92a3425bcb9b5a7711853bcc49e53d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-592](https://github.com/ursacomputing/crossbow/branches/all?query=actions-592)
|Task|Status|
|----|------|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-big-sur-cp39-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-macos-big-sur-cp39-universal2)|
|wheel-macos-high-sierra-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-macos-high-sierra-cp36-amd64)|
|wheel-macos-high-sierra-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-macos-high-sierra-cp37-amd64)|
|wheel-macos-high-sierra-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-macos-high-sierra-cp38-amd64)|
|wheel-macos-high-sierra-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-macos-high-sierra-cp39-amd64)|
|wheel-macos-mavericks-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-macos-mavericks-cp36-amd64)|
|wheel-macos-mavericks-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-macos-mavericks-cp37-amd64)|
|wheel-macos-mavericks-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-macos-mavericks-cp38-amd64)|
|wheel-macos-mavericks-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-macos-mavericks-cp39-amd64)|
|wheel-manylinux2010-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-manylinux2010-cp36-amd64)|
|wheel-manylinux2010-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-manylinux2010-cp37-amd64)|
|wheel-manylinux2010-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-manylinux2010-cp38-amd64)|
|wheel-manylinux2010-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-manylinux2010-cp39-amd64)|
|wheel-manylinux2014-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-manylinux2014-cp36-amd64)|
|wheel-manylinux2014-cp36-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-manylinux2014-cp37-amd64)|
|wheel-manylinux2014-cp37-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-manylinux2014-cp38-amd64)|
|wheel-manylinux2014-cp38-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-manylinux2014-cp39-amd64)|
|wheel-manylinux2014-cp39-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-windows-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-windows-cp36-amd64)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-windows-cp37-amd64)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-windows-cp38-amd64)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-592-github-wheel-windows-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mdagost commented on pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
mdagost commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-894701969
It's great to see wheel builds for Apple Silicon. Any chance you may back port them to older versions? The snowflake python connector still relies on versions of pyarrow>=3.0.0,<3.1.0, and I've gone through quite a few backflips but haven't been able to get pyarrow installed from source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-878660315
@kou could you please give it a preliminary review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r672332383
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1
ARROW_LZ4_BUILD_VERSION=v1.9.3
# mimalloc 1.6.7 didn't build on Visual Studio 2015
# https://github.com/microsoft/mimalloc/issues/353
-ARROW_MIMALLOC_BUILD_VERSION=v1.6.4
+ARROW_MIMALLOC_BUILD_VERSION=v1.7.2
Review comment:
As far as I can see that should only apply to 2.0.0 and 1.7.x should be safe (the commenter in https://github.com/microsoft/mimalloc/issues/363 claims 1.7.0 doesn't affect them at least)
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1
ARROW_LZ4_BUILD_VERSION=v1.9.3
# mimalloc 1.6.7 didn't build on Visual Studio 2015
# https://github.com/microsoft/mimalloc/issues/353
-ARROW_MIMALLOC_BUILD_VERSION=v1.6.4
+ARROW_MIMALLOC_BUILD_VERSION=v1.7.2
Review comment:
And the problematic test is still there - so assuming tests pass we should be OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-882712592
Revision: d29f104510839bad7fead1ff018a482236683b67
Submitted crossbow builds: [ursacomputing/crossbow @ actions-612](https://github.com/ursacomputing/crossbow/branches/all?query=actions-612)
|Task|Status|
|----|------|
|centos-7-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-centos-7-amd64)|
|centos-8-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-centos-8-amd64)|
|centos-8-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|conda-clean|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-clean)|
|conda-linux-gcc-py36-arm64|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-linux-gcc-py36-arm64)|
|conda-linux-gcc-py36-cpu-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-linux-gcc-py36-cpu-r40)|
|conda-linux-gcc-py36-cuda|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-linux-gcc-py36-cuda)|
|conda-linux-gcc-py37-arm64|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-linux-gcc-py37-arm64)|
|conda-linux-gcc-py37-cpu-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-linux-gcc-py37-cpu-r41)|
|conda-linux-gcc-py37-cuda|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-linux-gcc-py37-cuda)|
|conda-linux-gcc-py38-arm64|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-linux-gcc-py38-arm64)|
|conda-linux-gcc-py38-cpu|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-linux-gcc-py38-cpu)|
|conda-linux-gcc-py38-cuda|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-linux-gcc-py38-cuda)|
|conda-linux-gcc-py39-arm64|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-linux-gcc-py39-arm64)|
|conda-linux-gcc-py39-cpu|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-linux-gcc-py39-cpu)|
|conda-linux-gcc-py39-cuda|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-linux-gcc-py39-cuda)|
|conda-osx-arm64-clang-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-osx-arm64-clang-py38)|
|conda-osx-arm64-clang-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-osx-arm64-clang-py39)|
|conda-osx-clang-py36-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-osx-clang-py36-r40)|
|conda-osx-clang-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-osx-clang-py37-r41)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-osx-clang-py38)|
|conda-osx-clang-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-osx-clang-py39)|
|conda-win-vs2017-py36-r40|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-win-vs2017-py36-r40)|
|conda-win-vs2017-py37-r41|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-win-vs2017-py37-r41)|
|conda-win-vs2017-py38|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-win-vs2017-py38)|
|conda-win-vs2017-py39|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-conda-win-vs2017-py39)|
|debian-bullseye-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-debian-bullseye-amd64)|
|debian-bullseye-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|debian-buster-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-debian-buster-amd64)|
|debian-buster-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-example-cpp-minimal-build-static)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-example-cpp-minimal-build-static-system-dependency)|
|homebrew-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-homebrew-cpp)|
|homebrew-r-autobrew|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-homebrew-r-autobrew)|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-java-jars)|
|nuget|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-nuget)|
|python-sdist|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-python-sdist)|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-build-vcpkg-win)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-cpp-valgrind)|
|test-conda-python-3.6|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.6)|
|test-conda-python-3.6-pandas-0.23|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.6-pandas-0.23)|
|test-conda-python-3.7|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.7)|
|test-conda-python-3.7-dask-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.7-dask-latest)|
|test-conda-python-3.7-dask-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.7-dask-master)|
|test-conda-python-3.7-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.7-hdfs-2.9.2)|
|test-conda-python-3.7-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.7-hdfs-3.2.1)|
|test-conda-python-3.7-kartothek-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.7-kartothek-latest)|
|test-conda-python-3.7-kartothek-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.7-kartothek-master)|
|test-conda-python-3.7-pandas-0.24|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.7-pandas-0.24)|
|test-conda-python-3.7-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.7-pandas-latest)|
|test-conda-python-3.7-spark-branch-3.0|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.7-spark-branch-3.0)|
|test-conda-python-3.7-turbodbc-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.7-turbodbc-latest)|
|test-conda-python-3.7-turbodbc-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.7-turbodbc-master)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.8)|
|test-conda-python-3.8-hypothesis|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.8-hypothesis)|
|test-conda-python-3.8-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.8-pandas-latest)|
|test-conda-python-3.8-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.8-pandas-nightly)|
|test-conda-python-3.8-spark-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.8-spark-master)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.9)|
|test-conda-python-3.9-pandas-master|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-conda-python-3.9-pandas-master)|
|test-debian-10-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-debian-10-cpp)|
|test-debian-10-go-1.15|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-debian-10-go-1.15)|
|test-debian-10-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-debian-10-python-3)|
|test-debian-c-glib|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-debian-c-glib)|
|test-debian-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-debian-ruby)|
|test-fedora-33-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-fedora-33-cpp)|
|test-fedora-33-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-fedora-33-python-3)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-r-devdocs)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-r-gcc-11)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-r-install-local)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-r-linux-as-cran)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-r-linux-rchk)|
|test-r-linux-valgrind|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-r-linux-valgrind)|
|test-r-minimal-build|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-r-minimal-build)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-r-rhub-ubuntu-gcc-release-latest)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-r-rstudio-r-base-3.6-opensuse42)|
|test-r-rtools-35|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-r-rtools-35)|
|test-r-ubuntu-21.04|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-r-ubuntu-21.04)|
|test-r-version-compatibility|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-r-version-compatibility)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-r-versions)|
|test-r-without-arrow|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-r-without-arrow)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-18.04-python-3|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-ubuntu-18.04-python-3)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-ubuntu-18.04-r-sanitizer)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-ubuntu-20.04-cpp-thread-sanitizer)|
|test-ubuntu-20.10-docs|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-ubuntu-20.10-docs)|
|test-ubuntu-c-glib|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-ubuntu-c-glib)|
|test-ubuntu-default-docs|[](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-612-azure-test-ubuntu-default-docs)|
|test-ubuntu-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-test-ubuntu-ruby)|
|ubuntu-bionic-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-ubuntu-bionic-amd64)|
|ubuntu-bionic-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|ubuntu-focal-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-ubuntu-focal-amd64)|
|ubuntu-focal-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|ubuntu-groovy-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-ubuntu-groovy-amd64)|
|ubuntu-groovy-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|ubuntu-hirsute-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-ubuntu-hirsute-amd64)|
|ubuntu-hirsute-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-macos-big-sur-cp39-arm64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-macos-big-sur-cp39-arm64)|
|wheel-macos-big-sur-cp39-universal2|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-macos-big-sur-cp39-universal2)|
|wheel-macos-high-sierra-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-macos-high-sierra-cp36-amd64)|
|wheel-macos-high-sierra-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-macos-high-sierra-cp37-amd64)|
|wheel-macos-high-sierra-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-macos-high-sierra-cp38-amd64)|
|wheel-macos-high-sierra-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-macos-high-sierra-cp39-amd64)|
|wheel-macos-mavericks-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-macos-mavericks-cp36-amd64)|
|wheel-macos-mavericks-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-macos-mavericks-cp37-amd64)|
|wheel-macos-mavericks-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-macos-mavericks-cp38-amd64)|
|wheel-macos-mavericks-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-macos-mavericks-cp39-amd64)|
|wheel-manylinux2010-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-manylinux2010-cp36-amd64)|
|wheel-manylinux2010-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-manylinux2010-cp37-amd64)|
|wheel-manylinux2010-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-manylinux2010-cp38-amd64)|
|wheel-manylinux2010-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-manylinux2010-cp39-amd64)|
|wheel-manylinux2014-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-manylinux2014-cp36-amd64)|
|wheel-manylinux2014-cp36-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-manylinux2014-cp37-amd64)|
|wheel-manylinux2014-cp37-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-manylinux2014-cp38-amd64)|
|wheel-manylinux2014-cp38-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-manylinux2014-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-manylinux2014-cp39-amd64)|
|wheel-manylinux2014-cp39-arm64|[](https://travis-ci.com/ursacomputing/crossbow/branches)|
|wheel-windows-cp36-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-windows-cp36-amd64)|
|wheel-windows-cp37-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-windows-cp37-amd64)|
|wheel-windows-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-windows-cp38-amd64)|
|wheel-windows-cp39-amd64|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-612-github-wheel-windows-cp39-amd64)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r672328515
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1
ARROW_LZ4_BUILD_VERSION=v1.9.3
# mimalloc 1.6.7 didn't build on Visual Studio 2015
# https://github.com/microsoft/mimalloc/issues/353
-ARROW_MIMALLOC_BUILD_VERSION=v1.6.4
+ARROW_MIMALLOC_BUILD_VERSION=v1.7.2
Review comment:
@lidavidm how can I verify that https://github.com/apache/arrow/pull/10024 doesn't apply here?
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -42,7 +42,7 @@ ARROW_JEMALLOC_BUILD_VERSION=5.2.1
ARROW_LZ4_BUILD_VERSION=v1.9.3
# mimalloc 1.6.7 didn't build on Visual Studio 2015
# https://github.com/microsoft/mimalloc/issues/353
-ARROW_MIMALLOC_BUILD_VERSION=v1.6.4
+ARROW_MIMALLOC_BUILD_VERSION=v1.7.2
Review comment:
Thanks!
##########
File path: cpp/cmake_modules/FindSnappyAlt.cmake
##########
@@ -0,0 +1,117 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set(find_package_args)
Review comment:
Reverted.
##########
File path: dev/tasks/python-wheels/github.osx.arm64.yml
##########
@@ -0,0 +1,128 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Prerequisits on the host:
+# - brew install bash bison coreutils ninja cmake
+# - sudo arrow/ci/scripts/install_python.sh macos 3.9
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+env:
+ ARROW_S3: {{ arrow_s3 }}
+ ARROW_FLIGHT: OFF
+ ARROW_JEMALLOC: OFF
+ ARROW_SIMD_LEVEL: NONE
+ CC: "clang"
+ CMAKE_CXX_COMPILER_LAUNCHER: "ccache"
Review comment:
We need this to use ccache when compiling the vcpkg binaries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #10659:
URL: https://github.com/apache/arrow/pull/10659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879378309
@github-actions crossbow submit -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r669685196
##########
File path: python/requirements-wheel-build.txt
##########
@@ -1,6 +1,7 @@
cython>=0.29.11
numpy==1.16.6; python_version < "3.9" and platform_machine != "aarch64"
-numpy==1.19.4; python_version >= "3.9" or platform_machine == "aarch64"
-pandas<1.1.0; python_version < "3.8"
Review comment:
Yes, we shouldn't require pandas at build time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-879363719
@github-actions crossbow submit -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-10658: [Python][Packaging] Wheel builds for Apple Silicon
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-882712592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#issuecomment-878639817
@github-actions crossbow submit wheel-macos-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #10659: ARROW-12122: [Python] Cannot install via pip. M1 mac [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #10659:
URL: https://github.com/apache/arrow/pull/10659#discussion_r664170706
##########
File path: ci/scripts/python_wheel_macos_build.sh
##########
@@ -62,14 +62,18 @@ echo "=== (${PYTHON_VERSION}) Building Arrow C++ libraries ==="
mkdir -p ${build_dir}/build
pushd ${build_dir}/build
+
cmake \
+ -DCMAKE_APPLE_SILICON_PROCESSOR=arm64 \
Review comment:
We don't need to use the `CMAKE_SYSTEM_*` variables.
##########
File path: ci/scripts/python_wheel_macos_build.sh
##########
@@ -62,14 +62,18 @@ echo "=== (${PYTHON_VERSION}) Building Arrow C++ libraries ==="
mkdir -p ${build_dir}/build
pushd ${build_dir}/build
+
cmake \
+ -DCMAKE_APPLE_SILICON_PROCESSOR=arm64 \
-DARROW_BUILD_SHARED=ON \
+ -DARROW_SIMD_LEVEL=${ARROW_SIMD_LEVEL} \
+ -DARROW_RUNTIME_SIMD_LEVEL=NONE \
-DARROW_BUILD_STATIC=OFF \
-DARROW_BUILD_TESTS=OFF \
-DARROW_DATASET=${ARROW_DATASET} \
-DARROW_DEPENDENCY_SOURCE="VCPKG" \
-DARROW_DEPENDENCY_USE_SHARED=OFF \
- -DARROW_FLIGHT==${ARROW_FLIGHT} \
+ -DARROW_FLIGHT=${ARROW_FLIGHT} \
Review comment:
`gRPC` is not supported on apple silicon at the moment
##########
File path: ci/vcpkg/arm64-osx-static-release.cmake~
##########
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set(VCPKG_TARGET_ARCHITECTURE x64)
Review comment:
Need to remove this file.
##########
File path: cpp/cmake_modules/FindSnappyAlt.cmake
##########
@@ -0,0 +1,117 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+set(find_package_args)
Review comment:
Actually this snappy change wasn't required after using `CMAKE_APPLE_SILICON_PROCESSOR`
##########
File path: wheel.sh
##########
@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+arrow_dir=$1
+build_dir=$2
+
+export ARROW_FLIGHT=OFF
+export ARROW_JEMALLOC=OFF
+export ARROW_SIMD_LEVEL=NONE
+export BUILD_PREFIX=$build_dir
Review comment:
If we don't set `BUILD_PREFIX` to a non-existing location then [multibuild will set it to /usr/local](https://github.com/matthew-brett/multibuild/blob/devel/configure_build.sh#L71-L80) causing a pretty misleading cmake issue.
CMake tries to locate numpy's include path [by importing it](https://github.com/Kitware/CMake/blob/v3.19.2/Modules/FindPython/Support.cmake#L3075) swallowing any errors. If `BUILD_PREFIX` is set to `/usr/local` then multibuild will prepend `PATH` by `/usr/local/bin` which is brew's `x86_64` installation prefix. This causes the shell script to call the `x86_64` variant of `cmake` instead of the `arm64` one under `/opt/homebrew/bin` which calls the universal2 python binary as `x86_64` where importing an `arm64` compiled numpy will fail, but silently, making CMake unable to locate numpy for both compiling libarrow_python and pyarrow.
##########
File path: ci/scripts/python_wheel_macos_build.sh
##########
@@ -62,14 +62,18 @@ echo "=== (${PYTHON_VERSION}) Building Arrow C++ libraries ==="
mkdir -p ${build_dir}/build
pushd ${build_dir}/build
+
cmake \
+ -DCMAKE_APPLE_SILICON_PROCESSOR=arm64 \
-DARROW_BUILD_SHARED=ON \
+ -DARROW_SIMD_LEVEL=${ARROW_SIMD_LEVEL} \
+ -DARROW_RUNTIME_SIMD_LEVEL=NONE \
Review comment:
Remove this during the cleanup.
##########
File path: wheel.sh
##########
@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+arrow_dir=$1
+build_dir=$2
+
+export ARROW_FLIGHT=OFF
+export ARROW_JEMALLOC=OFF
+export ARROW_SIMD_LEVEL=NONE
+export BUILD_PREFIX=$build_dir
+export CONFIG_PATH=/dev/null
+export MACOSX_DEPLOYMENT_TARGET=11.0
+export MB_PYTHON_VERSION=3.9
+export PLAT=arm64
Review comment:
The produced wheel has universal2 platform tag, though my original plan is to provide a pure arm64 wheel in the first iteration.
##########
File path: wheel.sh
##########
@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+arrow_dir=$1
+build_dir=$2
+
+export ARROW_FLIGHT=OFF
+export ARROW_JEMALLOC=OFF
+export ARROW_SIMD_LEVEL=NONE
+export BUILD_PREFIX=$build_dir
+export CONFIG_PATH=/dev/null
+export MACOSX_DEPLOYMENT_TARGET=11.0
+export MB_PYTHON_VERSION=3.9
+export PLAT=arm64
Review comment:
Tried `export ARCHFLAGS=" -arch arm64"`, but still.
##########
File path: wheel.sh
##########
@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+arrow_dir=$1
+build_dir=$2
+
+export ARROW_FLIGHT=OFF
+export ARROW_JEMALLOC=OFF
+export ARROW_SIMD_LEVEL=NONE
+export BUILD_PREFIX=$build_dir
+export CONFIG_PATH=/dev/null
+export MACOSX_DEPLOYMENT_TARGET=11.0
+export MB_PYTHON_VERSION=3.9
+export PLAT=arm64
Review comment:
Tried to `export ARCHFLAGS=" -arch arm64"`, but still.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org