You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sj...@apache.org on 2022/02/11 17:48:56 UTC
[maven-surefire] 01/01: [SUREFIRE-2008] Upgrade animal-sniffer-maven-plugin to 1.21
This is an automated email from the ASF dual-hosted git repository.
sjaranowski pushed a commit to branch SUREFIRE-2008
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git
commit 21b7e2bf82abfd494f6c84e5ee3a1d4f9a8ee6e9
Author: Slawomir Jaranowski <s....@gmail.com>
AuthorDate: Fri Feb 11 18:45:46 2022 +0100
[SUREFIRE-2008] Upgrade animal-sniffer-maven-plugin to 1.21
---
pom.xml | 6 ++++--
.../apache/maven/surefire/api/stream/AbstractStreamDecoderTest.java | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/pom.xml b/pom.xml
index 579d550..6e86c8c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -452,11 +452,10 @@
<proc>none</proc>
</configuration>
</plugin>
- <!-- NOTE: animal sniffer does not check test classes: https://jira.codehaus.org/browse/MANIMALSNIFFER-40 -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>animal-sniffer-maven-plugin</artifactId>
- <version>1.17</version>
+ <version>1.21</version>
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
@@ -632,10 +631,13 @@
<executions>
<execution>
<id>signature-check</id>
+ <!-- we use offline jacoco instrumentation so check must be done after restoring original classes -->
+ <phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
<configuration>
+ <checkTestClasses>true</checkTestClasses>
<signature>
<groupId>org.codehaus.mojo.signature</groupId>
<artifactId>java18</artifactId>
diff --git a/surefire-api/src/test/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoderTest.java b/surefire-api/src/test/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoderTest.java
index 4c54df3..2dd9c72 100644
--- a/surefire-api/src/test/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoderTest.java
+++ b/surefire-api/src/test/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoderTest.java
@@ -318,7 +318,7 @@ public class AbstractStreamDecoderTest
Memento memento = thread.new Memento();
// whatever position will be compacted to 0
- ( (Buffer) ( (Buffer) memento.getByteBuffer().limit( 974 ) ) ).position( 974 );
+ ( (Buffer) memento.getByteBuffer() ).limit( 974 ).position( 974 );
StringBuilder expected = new StringBuilder( "789" );
for ( int i = 0; i < 11; i++ )