[PR] refactor: Convert `IPCWriter` metrics from `u64` to `usize` [datafusion]

["erenavsarogullari (via GitHub)" <gi...@apache.org>]

erenavsarogullari opened a new pull request, #10278:
URL: https://github.com/apache/datafusion/pull/10278

   ## Which issue does this PR close?
   Closes #9937.
   
   ## What changes are included in this PR?
   Currently, `IPCWriter` metrics types are `u64` based but source values are based on `usize` so this requires redundant casting on `IPCWriter.write()` and `ExternalSorter.spill()`. On the other hand, another benefit of `usize` is that it guarantees to reference enough memory location by depending on the architecture such as `u32` or `u64`.
   **Ref Discussion:** https://github.com/apache/datafusion/pull/9885#discussion_r1545794898
   
   ## Are these changes tested?
   Yes by using existing UT case such as `SortExec.test_sort_spill`
   
   ## Are there any user-facing changes?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] refactor: Convert `IPCWriter` metrics from `u64` to `usize` [datafusion]

["alamb (via GitHub)" <gi...@apache.org>]

alamb merged PR #10278:
URL: https://github.com/apache/datafusion/pull/10278


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org