You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/10/30 02:27:59 UTC

[GitHub] [bookkeeper] merlimat commented on a diff in pull request #3593: Removed the necessity of SafeRunnable

merlimat commented on code in PR #3593:
URL: https://github.com/apache/bookkeeper/pull/3593#discussion_r1008782207


##########
bookkeeper-common/src/main/java/org/apache/bookkeeper/common/util/OrderedExecutor.java:
##########
@@ -526,7 +520,7 @@ public boolean preserveMdc() {
      * @param orderingKey
      * @param r
      */
-    public void executeOrdered(Object orderingKey, SafeRunnable r) {
+    public void executeOrdered(Object orderingKey, Runnable r) {

Review Comment:
   `SafeRunnable` interface is not being removed and changing these methods to require `Runnable` should be ok since it's the "parent" interface.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org