You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/18 07:32:36 UTC

[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #12411: [Bug-12410] [API]Fix the worker list result in workflow definition only has default

ruanwenjun commented on code in PR #12411:
URL: https://github.com/apache/dolphinscheduler/pull/12411#discussion_r997825790


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckServiceImpl.java:
##########
@@ -371,13 +370,17 @@ public List<AuthorizationType> authorizationTypes() {
 
         @Override
         public boolean permissionCheck(int userId, String url, Logger logger) {
-            return false;
+            return true;

Review Comment:
   I find we return false in other methods in `ResourcePermissionCheckServiceImpl`, we may need to check this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org