You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by gc...@apache.org on 2010/11/01 19:39:07 UTC

svn commit: r1029788 - /myfaces/trinidad/branches/trinidad-1.2.x/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/SessionChangeManager.java

Author: gcrawford
Date: Mon Nov  1 18:39:06 2010
New Revision: 1029788

URL: http://svn.apache.org/viewvc?rev=1029788&view=rev
Log:
TRINIDAD-1949 SessionChangeManager failed to apply changes with page incluldes

Modified:
    myfaces/trinidad/branches/trinidad-1.2.x/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/SessionChangeManager.java

Modified: myfaces/trinidad/branches/trinidad-1.2.x/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/SessionChangeManager.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/branches/trinidad-1.2.x/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/SessionChangeManager.java?rev=1029788&r1=1029787&r2=1029788&view=diff
==============================================================================
--- myfaces/trinidad/branches/trinidad-1.2.x/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/SessionChangeManager.java (original)
+++ myfaces/trinidad/branches/trinidad-1.2.x/trinidad-api/src/main/java/org/apache/myfaces/trinidad/change/SessionChangeManager.java Mon Nov  1 18:39:06 2010
@@ -428,9 +428,14 @@ public class SessionChangeManager extend
    */
   private boolean _isStateRestored(FacesContext facesContext)
   {
-    boolean docCompCreated = Boolean.TRUE.equals(facesContext.getExternalContext().
-                                   getRequestMap().get(UIXComponentELTag.DOCUMENT_CREATED_KEY));
-    return (docCompCreated) ? false : RequestContext.getCurrentInstance().isPostback();
+    /*
+     * We will always return false for now. The reason is, if the page has a included fragment,
+     * and the fragment gets replaced during ppr, the changes inside the region will be lost.
+     */
+    return false;
+    //boolean docCompCreated = Boolean.TRUE.equals(facesContext.getExternalContext().
+    //                               getRequestMap().get(UIXComponentELTag.DOCUMENT_CREATED_KEY));
+    //return (docCompCreated) ? false : RequestContext.getCurrentInstance().isPostback();
   }  
 
   /**