You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/11/16 19:14:46 UTC
[GitHub] [lucene-solr] dsmiley opened a new pull request #2083: SOLR-15001 Docker: require init_var_solr.sh
dsmiley opened a new pull request #2083:
URL: https://github.com/apache/lucene-solr/pull/2083
https://issues.apache.org/jira/browse/SOLR-15001
There are two distinct commits here. The second is just to the build.gradle. I struggled with the Docker gradle build because the inputs/outputs were not configured correctly which confused Gradle's cool incremental build. I also disagree with defining a verbose class file inside a build file when it won't be re-used by other modules -- just do ad-hoc instead. Build automation is best suited to scripting languages IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #2083: SOLR-15001 Docker: require init_var_solr.sh
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #2083:
URL: https://github.com/apache/lucene-solr/pull/2083#issuecomment-731186192
Mike: Wow; it's embarrassing my PR broke that case. Thanks for your review!
I now made init_var_solr occur in the entrypoint, and thus it's guaranteed to run. Note that users can opt-out by setting NO_INIT_VAR_SOLR=yes if for some reason it's necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] HoustonPutman commented on pull request #2083: SOLR-15001 Docker: require init_var_solr.sh
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #2083:
URL: https://github.com/apache/lucene-solr/pull/2083#issuecomment-728316337
I agree with not liking the cumbersome Test class, the reason I added it was to allow for easy inclusion/exclusion rules for test cases. I think this PR loses that functionality. You could add it back in with
```groovy
testsInclude = propertyOrEnvOrDefault("solr.docker.tests.include", "SOLR_DOCKER_TESTS_INCLUDE", "")
testsExclude = propertyOrEnvOrDefault("solr.docker.tests.exclude", "SOLR_DOCKER_TESTS_EXCLUDE", "")
```
You would just need to edit `help/docker.txt` to make sure it's up to date with how to use the test inputs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #2083: SOLR-15001 Docker: require init_var_solr.sh
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #2083:
URL: https://github.com/apache/lucene-solr/pull/2083#issuecomment-728356772
Ah; thanks for pointing out the point of that configuration; now I see. I'll remove these changes from this PR and have a separate PR dedicated to overhauling/simplifying the Docker build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a change in pull request #2083: SOLR-15001 Docker: require init_var_solr.sh
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #2083:
URL: https://github.com/apache/lucene-solr/pull/2083#discussion_r526336171
##########
File path: solr/docker/include/scripts/init-var-solr
##########
@@ -31,31 +31,31 @@ function check_dir_writability {
}
if [ ! -d "$DIR/data" ]; then
- echo "Creating $DIR/data"
+ #echo "Creating $DIR/data"
check_dir_writability "$DIR"
mkdir "$DIR/data"
chmod 0770 "$DIR/data"
Review comment:
Combine these into `mkdir -m`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley merged pull request #2083: SOLR-15001 Docker: require init_var_solr.sh
Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #2083:
URL: https://github.com/apache/lucene-solr/pull/2083
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a change in pull request #2083: SOLR-15001 Docker: require init_var_solr.sh
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #2083:
URL: https://github.com/apache/lucene-solr/pull/2083#discussion_r526336171
##########
File path: solr/docker/include/scripts/init-var-solr
##########
@@ -31,31 +31,31 @@ function check_dir_writability {
}
if [ ! -d "$DIR/data" ]; then
- echo "Creating $DIR/data"
+ #echo "Creating $DIR/data"
check_dir_writability "$DIR"
mkdir "$DIR/data"
chmod 0770 "$DIR/data"
Review comment:
Combine these as above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org