[Axis2/C 1.3.0] fixing warnings on windows

[Senaka Fernando <se...@wso2.com>]

Hi devs,

Please take a look at this issue AXIS2C-573, [1], and provide your
feedback. We are looking forward to fix this for 1.3.0 and forever get rid
of this warning scenario on windows, and therefore, I expect your fullest
support.

[1] https://issues.apache.org/jira/browse/AXIS2C-573

Thanks,
Senaka

>
> Senaka Fernando updated AXIS2C-573:
> -----------------------------------
>
>     Attachment: warnings.rtf
>                 warnings.txt
>                 warnings.xls
>
> I have attached the list of remaining warnings (TXT, XLS, and RTF) when I
> build with /W4, which is apparently the highest. Below is an evaluation.
>
> 1. I have specifically disabled C4100, which can't be avoided due to our
> coding convention. This is due to un-used formal parameters.
>
> 2. Also, there are a great deal of warnings because we use
> AXIS2_HASH_KEY_STRING     (-1). The reason being we pass this constant to
> axis2_ssize_t which is an unsigned int. It is possible to specify cast
> this to unsigned int. But the better approach is to use (~0), which is the
> popular choice when it comes to unsigned int failure returns.
>
> 3. Even in some other places we return (-1) especially in string.c, where
> the return type is unsigned int.
>
> 4. Another issue is casting of function pointers, either using explicit
> casts or implicitly. These should not be explicitly casted I guess, at
> least because it generates two warnings. And, we can also disable C4152
> (implicit casting generates this). I don't see this as a problem.
>
> 5. Some others are due to use of old style declarators, deprecated
> function names etc. These can be corrected.
>
> 6. We do have some unreachable code (2-3 places). Better have a good look
> on these
>
> 7. Also, some C++ related stuff which can be ignored (actually I didn't
> build on the C mode).
>
> 8. However, warnings 74 - 78 need some thorough inspection.
>
> Therefore, I believe that if we could fix Nos. 2, 3, 4, 6, and 8, we can
> close this JIRA. The remaining Nos. are not so important.
>
>> Fix warnings on windows
>> ------------------------
>>
>>                 Key: AXIS2C-573
>>                 URL: https://issues.apache.org/jira/browse/AXIS2C-573
>>             Project: Axis2-C
>>          Issue Type: Bug
>>          Components: build system (Windows)
>>         Environment: Windows
>>            Reporter: Nandika Jayawardana
>>            Assignee: Senaka Fernando
>>             Fix For: 1.3.0
>>
>>         Attachments: warnings.rtf, warnings.txt, warnings.xls
>>
>>
>> When building axis2c source on windows, there are large number of
>> warnings. These warnings should be fixed
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-c-dev-help@ws.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org