You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/31 17:40:11 UTC

[GitHub] [airflow] potiuk opened a new pull request #13412: Set minimum SQLite version supported.

potiuk opened a new pull request #13412:
URL: https://github.com/apache/airflow/pull/13412


   Some users reported that some older versions of SQLite do not
   work with Airflow 2.0. This happens for example with latest
   sqlite available by default on RHEL7 (sqlite version available
   in fully updated system there is 7 (!) years old)
   
   Example of such issue: #13397.
   
   Not sure which 'minimum' version is supported but
   in the Breeze environment based on debian buster we have
   3.27.2 version in fully updated system. This shoudl be our
   baseline.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #13412: Set minimum SQLite version supported.

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13412:
URL: https://github.com/apache/airflow/pull/13412


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] XD-DENG commented on a change in pull request #13412: Set minimum SQLite version supported.

Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #13412:
URL: https://github.com/apache/airflow/pull/13412#discussion_r550678692



##########
File path: README.md
##########
@@ -89,7 +89,9 @@ Apache Airflow is tested with:
 **Note:** MariaDB and MySQL 5.x are unable to or have limitations with
 running multiple schedulers -- please see the "Scheduler" docs.
 
-**Note:** SQLite is used in Airflow tests. Do not use it in production.
+**Note:** SQLite is used in Airflow tests. Do not use it in production. We recommend
+using the latest stable version of SQLite for local development. Some older versions
+of sqlite might not work well, however anything at or above 3.27.2 should work fine.

Review comment:
       ```suggestion
   of SQLite might not work well, however anything at or above 3.27.2 should work fine.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #13412: Set minimum SQLite version supported.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13412:
URL: https://github.com/apache/airflow/pull/13412#issuecomment-753033792


   The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org