You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Juanjo Marron <jm...@us.ibm.com> on 2016/03/31 04:50:29 UTC
Review Request 45522: AMBARI-14472: Stack Featurize OozieService
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
Bugs: AMBARI-14472
https://issues.apache.org/jira/browse/AMBARI-14472
Repository: ambari
Description
-------
Stack Featurize Oozie Service
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/constants.py 54fbb8e
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py ac2dbd9
ambari-common/src/main/python/resource_management/libraries/script/script.py 4cbf2d7
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py 90851c8
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3b01802
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 4fc50d2
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py e9da71b
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 2db3672
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py ce44d5c
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py a08ae3a
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 974ddd7
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 1c80663
Diff: https://reviews.apache.org/r/45522/diff/
Testing
-------
mvn clean test -DskipSurefireTests
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3:58.802s
[INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
[INFO] Final Memory: 110M/796M
[INFO] ------------------------------------------------------------------------
[root@localhost ambari]#
Thanks,
Juanjo Marron
Re: Review Request 45522: AMBARI-14472: Stack Featurize OozieService
Posted by Juanjo Marron <jm...@us.ibm.com>.
> On March 31, 2016, 6:26 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json, line 123
> > <https://reviews.apache.org/r/45522/diff/1/?file=1320301#file1320301line123>
> >
> > Rename to oozie_create_hive_tez_configs instead?
Renamed to OOZIE_CREATE_HIVE_TEZ_CONFIGS = oozie_create_hive_tez_configs
- Juanjo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126277
-----------------------------------------------------------
On March 31, 2016, 2:50 a.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 2:50 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Featurize Oozie Service
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 54fbb8e
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py ac2dbd9
> ambari-common/src/main/python/resource_management/libraries/script/script.py 4cbf2d7
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py 90851c8
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3b01802
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 4fc50d2
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py e9da71b
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 2db3672
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py ce44d5c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py a08ae3a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 974ddd7
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 1c80663
>
> Diff: https://reviews.apache.org/r/45522/diff/
>
>
> Testing
> -------
>
> mvn clean test -DskipSurefireTests
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] ------------------------------------------------------------------------
> [root@localhost ambari]#
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45522: AMBARI-14472: Stack Featurize OozieService
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126277
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json (line 123)
<https://reviews.apache.org/r/45522/#comment189213>
Rename to oozie_create_hive_tez_configs instead?
- Jayush Luniya
On March 31, 2016, 2:50 a.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 2:50 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Featurize Oozie Service
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 54fbb8e
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py ac2dbd9
> ambari-common/src/main/python/resource_management/libraries/script/script.py 4cbf2d7
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py 90851c8
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3b01802
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 4fc50d2
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py e9da71b
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 2db3672
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py ce44d5c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py a08ae3a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 974ddd7
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 1c80663
>
> Diff: https://reviews.apache.org/r/45522/diff/
>
>
> Testing
> -------
>
> mvn clean test -DskipSurefireTests
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] ------------------------------------------------------------------------
> [root@localhost ambari]#
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126611
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 1, 2016, 5:31 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 5:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Featurize Oozie Service
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 175b889
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 6169699
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py 90851c8
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3b01802
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 4fc50d2
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py e9da71b
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 2db3672
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py ce44d5c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py a08ae3a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json fd3fbde
>
> Diff: https://reviews.apache.org/r/45522/diff/
>
>
> Testing
> -------
>
> mvn clean test -DskipSurefireTests
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] ------------------------------------------------------------------------
> [root@localhost ambari]#
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126863
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On April 1, 2016, 5:31 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 5:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Featurize Oozie Service
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 175b889
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 6169699
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py 90851c8
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3b01802
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 4fc50d2
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py e9da71b
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 2db3672
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py ce44d5c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py a08ae3a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json fd3fbde
>
> Diff: https://reviews.apache.org/r/45522/diff/
>
>
> Testing
> -------
>
> mvn clean test -DskipSurefireTests
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] ------------------------------------------------------------------------
> [root@localhost ambari]#
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service
Posted by Juanjo Marron <jm...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/
-----------------------------------------------------------
(Updated April 1, 2016, 5:31 p.m.)
Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
Summary (updated)
-----------------
AMBARI-14472: Stack Featurize Oozie Service
Bugs: AMBARI-14472
https://issues.apache.org/jira/browse/AMBARI-14472
Repository: ambari
Description
-------
Stack Featurize Oozie Service
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/constants.py 175b889
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 6169699
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py 90851c8
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3b01802
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 4fc50d2
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py e9da71b
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 2db3672
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py ce44d5c
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py a08ae3a
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json fd3fbde
Diff: https://reviews.apache.org/r/45522/diff/
Testing
-------
mvn clean test -DskipSurefireTests
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3:58.802s
[INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
[INFO] Final Memory: 110M/796M
[INFO] ------------------------------------------------------------------------
[root@localhost ambari]#
Thanks,
Juanjo Marron
Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service
Posted by Juanjo Marron <jm...@us.ibm.com>.
> On March 31, 2016, 6:12 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py, line 114
> > <https://reviews.apache.org/r/45522/diff/1/?file=1320297#file1320297line114>
> >
> > Let me check if this restriction for 2.2.1.0 is Oozie specific.
>
> Juanjo Marron wrote:
> Maintained for now in the new patch. Please, let me know if it needs to be edited
>
> Jayush Luniya wrote:
> @Juanjo. I didnt get a chance to look into this. For now lets leave these feature as LZO itself and since your logic is correct go ahead with the change. We can rename if required the feature to oozie_lzo or something like that if this is Oozie specific.
Thanks @Jayush.
I did that and the new patch was uploaded and it is available to be reviewed and committed
- Juanjo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126274
-----------------------------------------------------------
On April 1, 2016, 5:31 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 5:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Featurize Oozie Service
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 175b889
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 6169699
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py 90851c8
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3b01802
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 4fc50d2
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py e9da71b
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 2db3672
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py ce44d5c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py a08ae3a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json fd3fbde
>
> Diff: https://reviews.apache.org/r/45522/diff/
>
>
> Testing
> -------
>
> mvn clean test -DskipSurefireTests
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] ------------------------------------------------------------------------
> [root@localhost ambari]#
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service
Posted by Juanjo Marron <jm...@us.ibm.com>.
> On March 31, 2016, 6:12 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py, line 114
> > <https://reviews.apache.org/r/45522/diff/1/?file=1320297#file1320297line114>
> >
> > Let me check if this restriction for 2.2.1.0 is Oozie specific.
>
> Juanjo Marron wrote:
> Maintained for now in the new patch. Please, let me know if it needs to be edited
>
> Jayush Luniya wrote:
> @Juanjo. I didnt get a chance to look into this. For now lets leave these feature as LZO itself and since your logic is correct go ahead with the change. We can rename if required the feature to oozie_lzo or something like that if this is Oozie specific.
>
> Juanjo Marron wrote:
> Thanks @Jayush.
> I did that and the new patch was uploaded and it is available to be reviewed and committed
>
> Jayush Luniya wrote:
> Yes, committed to trunk
Thanks!
- Juanjo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126274
-----------------------------------------------------------
On April 1, 2016, 5:31 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 5:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Featurize Oozie Service
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 175b889
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 6169699
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py 90851c8
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3b01802
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 4fc50d2
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py e9da71b
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 2db3672
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py ce44d5c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py a08ae3a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json fd3fbde
>
> Diff: https://reviews.apache.org/r/45522/diff/
>
>
> Testing
> -------
>
> mvn clean test -DskipSurefireTests
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] ------------------------------------------------------------------------
> [root@localhost ambari]#
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45522: AMBARI-14472: Stack Featurize OozieService
Posted by Juanjo Marron <jm...@us.ibm.com>.
> On March 31, 2016, 6:12 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py, line 132
> > <https://reviews.apache.org/r/45522/diff/1/?file=1320298#file1320298line132>
> >
> > Lets just use stack_name.upper() to set this for now and remove the HDP hardcoding.
Since HIVE was also using /usr/share/HDP-hive I thoughjt it could be a good idea to abstract it as a property.
But you are right, the path is not even an existing directory
> On March 31, 2016, 6:12 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py, line 114
> > <https://reviews.apache.org/r/45522/diff/1/?file=1320297#file1320297line114>
> >
> > Let me check if this restriction for 2.2.1.0 is Oozie specific.
Maintained for now in the new patch. Please, let me know if it needs to be edited
- Juanjo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126274
-----------------------------------------------------------
On March 31, 2016, 2:50 a.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 2:50 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Featurize Oozie Service
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 54fbb8e
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py ac2dbd9
> ambari-common/src/main/python/resource_management/libraries/script/script.py 4cbf2d7
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py 90851c8
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3b01802
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 4fc50d2
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py e9da71b
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 2db3672
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py ce44d5c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py a08ae3a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 974ddd7
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 1c80663
>
> Diff: https://reviews.apache.org/r/45522/diff/
>
>
> Testing
> -------
>
> mvn clean test -DskipSurefireTests
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] ------------------------------------------------------------------------
> [root@localhost ambari]#
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On March 31, 2016, 6:12 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py, line 114
> > <https://reviews.apache.org/r/45522/diff/1/?file=1320297#file1320297line114>
> >
> > Let me check if this restriction for 2.2.1.0 is Oozie specific.
>
> Juanjo Marron wrote:
> Maintained for now in the new patch. Please, let me know if it needs to be edited
@Juanjo. I didnt get a chance to look into this. For now lets leave these feature as LZO itself and since your logic is correct go ahead with the change. We can rename if required the feature to oozie_lzo or something like that if this is Oozie specific.
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126274
-----------------------------------------------------------
On April 1, 2016, 5:31 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 5:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Featurize Oozie Service
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 175b889
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 6169699
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py 90851c8
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3b01802
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 4fc50d2
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py e9da71b
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 2db3672
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py ce44d5c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py a08ae3a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json fd3fbde
>
> Diff: https://reviews.apache.org/r/45522/diff/
>
>
> Testing
> -------
>
> mvn clean test -DskipSurefireTests
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] ------------------------------------------------------------------------
> [root@localhost ambari]#
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45522: AMBARI-14472: Stack Featurize Oozie Service
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On March 31, 2016, 6:12 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py, line 114
> > <https://reviews.apache.org/r/45522/diff/1/?file=1320297#file1320297line114>
> >
> > Let me check if this restriction for 2.2.1.0 is Oozie specific.
>
> Juanjo Marron wrote:
> Maintained for now in the new patch. Please, let me know if it needs to be edited
>
> Jayush Luniya wrote:
> @Juanjo. I didnt get a chance to look into this. For now lets leave these feature as LZO itself and since your logic is correct go ahead with the change. We can rename if required the feature to oozie_lzo or something like that if this is Oozie specific.
>
> Juanjo Marron wrote:
> Thanks @Jayush.
> I did that and the new patch was uploaded and it is available to be reviewed and committed
Yes, committed to trunk
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126274
-----------------------------------------------------------
On April 1, 2016, 5:31 p.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 5:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Featurize Oozie Service
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 175b889
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 6169699
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py 90851c8
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3b01802
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 4fc50d2
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py e9da71b
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 2db3672
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py ce44d5c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py a08ae3a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json fd3fbde
>
> Diff: https://reviews.apache.org/r/45522/diff/
>
>
> Testing
> -------
>
> mvn clean test -DskipSurefireTests
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] ------------------------------------------------------------------------
> [root@localhost ambari]#
>
>
> Thanks,
>
> Juanjo Marron
>
>
Re: Review Request 45522: AMBARI-14472: Stack Featurize OozieService
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45522/#review126274
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
<https://reviews.apache.org/r/45522/#comment189212>
Let me check if this restriction for 2.2.1.0 is Oozie specific.
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py (line 130)
<https://reviews.apache.org/r/45522/#comment189208>
Lets just use stack_name.upper() to set this for now and remove the HDP hardcoding.
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml (line 194)
<https://reviews.apache.org/r/45522/#comment189207>
This path isnt valid. For Oozie the directory is /usr/share/HDP-oozie. Lets not set this to /usr/share/HDP as it does not exist.
Also I dont think we should add a stack_share_dir in this case until we have a constructive plan on how the stack_shared_dir will be used.
Using for just /usr/share/HDP-oozie doesnt look correct.
- Jayush Luniya
On March 31, 2016, 2:50 a.m., Juanjo Marron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45522/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 2:50 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
>
>
> Bugs: AMBARI-14472
> https://issues.apache.org/jira/browse/AMBARI-14472
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Stack Featurize Oozie Service
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 54fbb8e
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py ac2dbd9
> ambari-common/src/main/python/resource_management/libraries/script/script.py 4cbf2d7
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/alerts/alert_check_oozie_server.py 90851c8
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 3b01802
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py 4fc50d2
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py e9da71b
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py 2db3672
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py ce44d5c
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/status_params.py a08ae3a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 974ddd7
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 1c80663
>
> Diff: https://reviews.apache.org/r/45522/diff/
>
>
> Testing
> -------
>
> mvn clean test -DskipSurefireTests
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 3:58.802s
> [INFO] Finished at: Wed Mar 30 18:57:06 PDT 2016
> [INFO] Final Memory: 110M/796M
> [INFO] ------------------------------------------------------------------------
> [root@localhost ambari]#
>
>
> Thanks,
>
> Juanjo Marron
>
>