[jira] [Commented] (DISPATCH-1595) Python tests define on_modified handler when proton has none

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DISPATCH-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340863#comment-17340863 ] 

ASF GitHub Bot commented on DISPATCH-1595:
------------------------------------------

ChugR opened a new pull request #1196:
URL: https://github.com/apache/qpid-dispatch/pull/1196


   There is no on_modified event in proton python MessagingHandler.
   Proton conflates Delivery.MODIFIED and Delivery.RELEASED state handling
   and delivers both states in the on_released handler.
       
   This patch makes the dispatch handler model precisely reflect the
   proton handler model.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Python tests define on_modified handler when proton has none
> ------------------------------------------------------------
>
>                 Key: DISPATCH-1595
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1595
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.10.0
>            Reporter: Charles E. Rolke
>            Priority: Major
>
> Proton python deliberately lumps modified and released dispositions into the on_released callback. There is no on_modified callback.
> system_tests.py and system_tests_multicast.py mistakenly add an on_modifed callback that does not override anything and is never called by proton.
> See https://issues.apache.org/jira/browse/PROTON-2180



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org