You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2013/08/13 18:49:32 UTC
Review Request 13536: [OOZIE-1495] inconsistent behavior of chmod/chgrp when
path doesn't exist after glob support
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13536/
-----------------------------------------------------------
Review request for oozie.
Bugs: oozie-1495
https://issues.apache.org/jira/browse/oozie-1495
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1495
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1513573
Diff: https://reviews.apache.org/r/13536/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request 13536: [OOZIE-1495] inconsistent behavior of chmod/chgrp
when path doesn't exist after glob support
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13536/#review25074
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java
<https://reviews.apache.org/r/13536/#comment49252>
Can you check if you have to do resolveToFullPath before globbing? Doing it after might not work for some cases.
- Rohini Palaniswamy
On Aug. 13, 2013, 4:49 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13536/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2013, 4:49 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: oozie-1495
> https://issues.apache.org/jira/browse/oozie-1495
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1495
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1513573
>
> Diff: https://reviews.apache.org/r/13536/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 13536: [OOZIE-1495] inconsistent behavior of chmod/chgrp
when path doesn't exist after glob support
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13536/#review25147
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On Aug. 14, 2013, 7:50 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13536/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2013, 7:50 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: oozie-1495
> https://issues.apache.org/jira/browse/oozie-1495
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1495
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1513573
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1513573
>
> Diff: https://reviews.apache.org/r/13536/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 13536: [OOZIE-1495] inconsistent behavior of chmod/chgrp
when path doesn't exist after glob support
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13536/
-----------------------------------------------------------
(Updated Aug. 14, 2013, 7:50 a.m.)
Review request for oozie.
Changes
-------
fixed comments
Bugs: oozie-1495
https://issues.apache.org/jira/browse/oozie-1495
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1495
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1513573
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1513573
Diff: https://reviews.apache.org/r/13536/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request 13536: [OOZIE-1495] inconsistent behavior of chmod/chgrp
when path doesn't exist after glob support
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13536/#review25110
-----------------------------------------------------------
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java
<https://reviews.apache.org/r/13536/#comment49334>
This testcase does not help. Even the current code will pass with this testcase without the fix in this patch. Please add testcase that exercises resolveToFullPath through chmod or chgrp given a namenodePath instead of just absolute path.
- Rohini Palaniswamy
On Aug. 13, 2013, 11:40 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13536/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2013, 11:40 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: oozie-1495
> https://issues.apache.org/jira/browse/oozie-1495
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1495
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1513573
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1513573
>
> Diff: https://reviews.apache.org/r/13536/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 13536: [OOZIE-1495] inconsistent behavior of chmod/chgrp
when path doesn't exist after glob support
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13536/
-----------------------------------------------------------
(Updated Aug. 13, 2013, 11:40 p.m.)
Review request for oozie.
Changes
-------
added test
Bugs: oozie-1495
https://issues.apache.org/jira/browse/oozie-1495
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1495
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1513573
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1513573
Diff: https://reviews.apache.org/r/13536/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request 13536: [OOZIE-1495] inconsistent behavior of chmod/chgrp
when path doesn't exist after glob support
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13536/
-----------------------------------------------------------
(Updated Aug. 13, 2013, 10:14 p.m.)
Review request for oozie.
Changes
-------
thx for pointing this out, Rohini,
I fixed it by moving resolveToFullPath before glob.
Bugs: oozie-1495
https://issues.apache.org/jira/browse/oozie-1495
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1495
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1513573
Diff: https://reviews.apache.org/r/13536/diff/
Testing
-------
Thanks,
Ryota Egashira