You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Di Xu (Jira)" <ji...@apache.org> on 2020/10/10 01:38:00 UTC

[jira] [Comment Edited] (FLINK-17613) Run K8s related e2e tests with multiple K8s versions

    [ https://issues.apache.org/jira/browse/FLINK-17613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201894#comment-17201894 ] 

Di Xu edited comment on FLINK-17613 at 10/10/20, 1:37 AM:
----------------------------------------------------------

[~rmetzger] and [~fly_in_gis] I would like to take this ticket. Here is the proposed solution:

1. Determine kubernetes version range to test against

minikube follows[1] the Kubernetes Version and Version Skew Support Policy[2] which indicates that the most recent three minor releases are maintained. At the time of writing, v1.19.2, v1.18.9 and v1.17.12 are versions we should test against according to the release page[3].

I am not aware any API to obtain the versions so my plan is to put them into common_kubernetes.sh. If you know better ways please suggest here.

2. Modify test_kubernetes_*.sh to loop over the versions and run test. Moreover,
 * in case of Linux, add --kubernetes-version=<> to minikube command to start specific kubernetes version
 * in case of Non-Linux, check the pre-started kubernetes version by 'kubectl version --short' (follows the minikube status check) and ensure it matches the version we want to test against, otherwise fails the test and give hint to user.

 

[1] [https://minikube.sigs.k8s.io/docs/handbook/config/#selecting-a-kubernetes-version]

[2] [https://kubernetes.io/docs/setup/release/version-skew-policy/]

[3] [https://github.com/kubernetes/kubernetes/releases]

 

update 1:

for non-linux os (normally it is the developer's environment), just test against user-installed k8s cluster no matter what version it is.

 

update 2:

Follow this discussion[4], to save testing time, we only test against the latest stable version for each pull request, and in the nightly build we test against all k8s versions.

[4] https://github.com/apache/flink/pull/13555#issuecomment-706119094


was (Author: xudi):
[~rmetzger] and [~fly_in_gis] I would like to take this ticket. Here is the proposed solution:

1. Determine kubernetes version range to test against

minikube follows[1] the Kubernetes Version and Version Skew Support Policy[2] which indicates that the most recent three minor releases are maintained. At the time of writing, v1.19.2, v1.18.9 and v1.17.12 are versions we should test against according to the release page[3].

I am not aware any API to obtain the versions so my plan is to put them into common_kubernetes.sh. If you know better ways please suggest here.

2. Modify test_kubernetes_*.sh to loop over the versions and run test. Moreover,
 * in case of Linux, add --kubernetes-version=<> to minikube command to start specific kubernetes version
 * in case of Non-Linux, check the pre-started kubernetes version by 'kubectl version --short' (follows the minikube status check) and ensure it matches the version we want to test against, otherwise fails the test and give hint to user.

 

[1] [https://minikube.sigs.k8s.io/docs/handbook/config/#selecting-a-kubernetes-version]

[2] [https://kubernetes.io/docs/setup/release/version-skew-policy/]

[3] [https://github.com/kubernetes/kubernetes/releases]

> Run K8s related e2e tests with multiple K8s versions
> ----------------------------------------------------
>
>                 Key: FLINK-17613
>                 URL: https://issues.apache.org/jira/browse/FLINK-17613
>             Project: Flink
>          Issue Type: Improvement
>          Components: Deployment / Kubernetes, Tests
>            Reporter: Yang Wang
>            Assignee: Di Xu
>            Priority: Major
>              Labels: pull-request-available, starter
>
> Follow the discussion in this PR [1].
> If we could run the K8s related e2e tests in multiple versions(the latest version, oldest maintained version, etc.), it will help us to find the usability issues earlier before users post them in the user ML[2]. 
> [1].https://github.com/apache/flink/pull/12071#discussion_r422838483
> [2].https://lists.apache.org/list.html?user@flink.apache.org:lte=1M:Cannot%20start%20native%20K8s



--
This message was sent by Atlassian Jira
(v8.3.4#803005)