You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/08/21 15:43:16 UTC
[GitHub] [incubator-kvrocks] mathspanda opened a new issue, #783: Expose some stats in RocksDB Perf Context and IO Stats Context
mathspanda opened a new issue, #783:
URL: https://github.com/apache/incubator-kvrocks/issues/783
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
### Motivation
Stats in Perf Context or IO Stat Context are useful to pinpoint some performance issues of redis commands.
For example, Counters `internal_delete_skipped_count` could illustrate why `zrangebyscore` is so slow if there is too many tombstones.
### Solution
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Expose some stats in RocksDB Perf Context and IO Stats Context [kvrocks]
Posted by "chrisxu333 (via GitHub)" <gi...@apache.org>.
chrisxu333 commented on issue #783:
URL: https://github.com/apache/kvrocks/issues/783#issuecomment-1826830869
As I'm thinking, this exposure of rocksdb perf and io stats would incur additional costs, so we maybe need a toggle to control it? Do you guys have any idea how to incorporate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] mathspanda commented on issue #783: Expose some stats in RocksDB Perf Context and IO Stats Context
Posted by GitBox <gi...@apache.org>.
mathspanda commented on issue #783:
URL: https://github.com/apache/incubator-kvrocks/issues/783#issuecomment-1222521870
> @mathspanda Thanks for your report, `internal_delete_skipped_count ` makes a lot sense, would you like to contribute it?
👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on issue #783: Expose some stats in RocksDB Perf Context and IO Stats Context
Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #783:
URL: https://github.com/apache/incubator-kvrocks/issues/783#issuecomment-1221791405
@mathspanda Thanks for your report, `internal_delete_skipped_count ` makes a lot sense, would you like to contribute it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Expose some stats in RocksDB Perf Context and IO Stats Context [kvrocks]
Posted by "chrisxu333 (via GitHub)" <gi...@apache.org>.
chrisxu333 commented on issue #783:
URL: https://github.com/apache/kvrocks/issues/783#issuecomment-1826880117
> @git-hulk As I'm thinking, this exposure of rocksdb perf and io stats would incur additional costs, so we maybe need a toggle to control it? Also what would be the proper way of displaying such stats, I'm thinking include them inside the result of `info` command?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Expose some stats in RocksDB Perf Context and IO Stats Context [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #783:
URL: https://github.com/apache/kvrocks/issues/783#issuecomment-1826389942
@chrisxu333 Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Expose some stats in RocksDB Perf Context and IO Stats Context [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk closed issue #783: Expose some stats in RocksDB Perf Context and IO Stats Context
URL: https://github.com/apache/kvrocks/issues/783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Expose some stats in RocksDB Perf Context and IO Stats Context [kvrocks]
Posted by "chrisxu333 (via GitHub)" <gi...@apache.org>.
chrisxu333 commented on issue #783:
URL: https://github.com/apache/kvrocks/issues/783#issuecomment-1860742423
Hi @git-hulk and @PragmaTwice , I've opened a pr for this issue. Please help review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Expose some stats in RocksDB Perf Context and IO Stats Context [kvrocks]
Posted by "chrisxu333 (via GitHub)" <gi...@apache.org>.
chrisxu333 commented on issue #783:
URL: https://github.com/apache/kvrocks/issues/783#issuecomment-1828059700
> Hi @chrisxu333
>
> Yes, I didn't think through this issue. It's not only about how to display the information but also how to collect that perf information since we don't enable them by default.
Sounds good I'll try to figure out a design :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Expose some stats in RocksDB Perf Context and IO Stats Context [kvrocks]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on issue #783:
URL: https://github.com/apache/kvrocks/issues/783#issuecomment-1826741901
https://github.com/apache/kvrocks/pull/1902
As mentioned here, maybe compaction-cpu-time can also be added here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Expose some stats in RocksDB Perf Context and IO Stats Context [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #783:
URL: https://github.com/apache/kvrocks/issues/783#issuecomment-1827783725
Hi @chrisxu333
Yes, I didn't think through this issue. It's not only about how to display the information, but also how to collect those perf information since we don't enable them by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Expose some stats in RocksDB Perf Context and IO Stats Context [kvrocks]
Posted by "chrisxu333 (via GitHub)" <gi...@apache.org>.
chrisxu333 commented on issue #783:
URL: https://github.com/apache/kvrocks/issues/783#issuecomment-1826386816
Hi @git-hulk , if nobody is working on this, can I take over?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org