You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/14 01:09:22 UTC
[GitHub] [pulsar] liudezhi2098 opened a new pull request #13749: Enable CheckStyle Plugin in auth module
liudezhi2098 opened a new pull request #13749:
URL: https://github.com/apache/pulsar/pull/13749
Motivation
enable checkStyle_plugin in pulsar-broker-auth-athen module.
enable checkStyle_plugin in pulsar-broker-auth-sasl module.
enable checkStyle_plugin in pulsar-client-auth-athenz module.
enable checkStyle_plugin in pulsar-client-auth-sasl module.
Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liudezhi2098 commented on pull request #13749: Enable CheckStyle Plugin in auth module
Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on pull request #13749:
URL: https://github.com/apache/pulsar/pull/13749#issuecomment-1013108855
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #13749: Enable CheckStyle Plugin in auth module
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #13749:
URL: https://github.com/apache/pulsar/pull/13749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on a change in pull request #13749: Enable CheckStyle Plugin in auth module
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on a change in pull request #13749:
URL: https://github.com/apache/pulsar/pull/13749#discussion_r784448956
##########
File path: pulsar-client-auth-athenz/src/main/java/org/apache/pulsar/client/impl/auth/package-info.java
##########
@@ -0,0 +1,23 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/**
+ * Helper class to access AirCompressor package private classes.
+ */
+package org.apache.pulsar.client.impl.auth;
Review comment:
better to a new line on file end
##########
File path: pulsar-client-auth-sasl/src/main/java/org/apache/pulsar/client/impl/auth/package-info.java
##########
@@ -0,0 +1,23 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/**
+ * Helper class to access AirCompressor package private classes.
+ */
+package org.apache.pulsar.client.impl.auth;
Review comment:
better to a new line on file end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org