You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/08/12 03:20:40 UTC

[GitHub] [trafficcontrol] rawlinp opened a new pull request #6100: Remove more unused TM config options

rawlinp opened a new pull request #6100:
URL: https://github.com/apache/trafficcontrol/pull/6100


   Remove the following TM config options which appear to be used but
   actually aren't, due to them having a corresponding profile parameter:
   - cache_health_polling_interval_ms
   - cache_stat_polling_interval_ms
   - peer_polling_interval_ms
   
   These are actually unused because the following profile parameters take
   precedence as soon as the monitoring.json snapshot is retrieved from TO:
   - heartbeat.polling.interval
   - health.polling.interval
   - peers.polling.interval
   
   Additionally, do some minor cleanup of unused functions, unused
   parameters, and comments.
   
   -----------------------------------------------
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Monitor
   - Automation (Ansible roles)
   
   ## What is the best way to verify this PR?
   Ensure that TM still starts up and performs its cache health polling using the interval in the `heartbeat.polling.interval` profile parameter, its cache stat polling using the interval in the `health.polling.interval` profile parameter, and its peer polling using the interval in the `peers.polling.interval` profile parameter.
   
   ## PR submission checklist
   - [x] This PR updates the tests to remove the unused configuration, but it doesn't really make sense to test the removal of config options.
   - [x] These config options were not documented
   - [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 commented on pull request #6100: Remove more unused TM config options

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on pull request #6100:
URL: https://github.com/apache/trafficcontrol/pull/6100#issuecomment-897772466


   > No, if the parameters don't exist, the Monitor Config Manager goroutine never sends the monitor config to the other poller goroutines. It will continue polling for a monitoring snapshot in which those parameters actually exist.
   
   It looks like that's true for `health.polling.interval` and `peers.polling.interval` but not `heartbeat.polling.interval`. In that last case, it looks like it logs a warning and defaults to `health.polling.interval`, which I'm realizing as I type this means that the default set by the configuration file would still be unused.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp commented on pull request #6100: Remove more unused TM config options

Posted by GitBox <gi...@apache.org>.
rawlinp commented on pull request #6100:
URL: https://github.com/apache/trafficcontrol/pull/6100#issuecomment-897715312


   No, if the parameters don't exist, the Monitor Config Manager goroutine never sends the monitor config to the other poller goroutines. It will continue polling for a monitoring snapshot in which those parameters actually exist.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman merged pull request #6100: Remove more unused TM config options

Posted by GitBox <gi...@apache.org>.
zrhoffman merged pull request #6100:
URL: https://github.com/apache/trafficcontrol/pull/6100


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] ocket8888 commented on pull request #6100: Remove more unused TM config options

Posted by GitBox <gi...@apache.org>.
ocket8888 commented on pull request #6100:
URL: https://github.com/apache/trafficcontrol/pull/6100#issuecomment-897370210


   > These are actually unused because the following profile parameters take precedence as soon as the monitoring.json snapshot is retrieved from TO
   
   Are they used in the case that said Parameters don't exist?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org