You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2019/12/25 10:07:37 UTC

[GitHub] [incubator-apisix] imlewc opened a new pull request #1000: https://github.com/apache/incubator-apisix/issues/986

imlewc opened a new pull request #1000: https://github.com/apache/incubator-apisix/issues/986
URL: https://github.com/apache/incubator-apisix/pull/1000
 
 
   ### Summary
   
   add whiteiplist in limit count plugin
   
   ### Issues resolved
   
   Fix #986
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on issue #1000: add whiteiplist in limit count plugin

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1000: add whiteiplist in limit count plugin
URL: https://github.com/apache/incubator-apisix/pull/1000#issuecomment-568955123
 
 
   please add some test case about this feature.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1000: add whiteiplist in limit count plugin

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1000: add whiteiplist in limit count plugin
URL: https://github.com/apache/incubator-apisix/pull/1000#discussion_r361355967
 
 

 ##########
 File path: lua/apisix/plugins/limit-count.lua
 ##########
 @@ -48,6 +55,11 @@ local schema = {
         redis_timeout = {
             type = "integer", minimum = 1
         },
+        whitelist = {
 
 Review comment:
   `whitelist` to `ip_whitelist`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis edited a comment on issue #1000: add whiteiplist in limit count plugin

Posted by GitBox <gi...@apache.org>.
membphis edited a comment on issue #1000: add whiteiplist in limit count plugin
URL: https://github.com/apache/incubator-apisix/pull/1000#issuecomment-568955123
 
 
   Please add some test case about this feature.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming commented on pull request #1000: add whiteiplist in limit count plugin

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #1000:
URL: https://github.com/apache/incubator-apisix/pull/1000#issuecomment-661607475


   this PR that hasn't been updated for a long time, close it first


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] moonming closed pull request #1000: add whiteiplist in limit count plugin

Posted by GitBox <gi...@apache.org>.
moonming closed pull request #1000:
URL: https://github.com/apache/incubator-apisix/pull/1000


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org