You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yixiutt (via GitHub)" <gi...@apache.org> on 2023/02/13 02:16:41 UTC

[GitHub] [doris] yixiutt commented on a diff in pull request #16605: [bugfix](column_reader) index_page should not be pre-decoded

yixiutt commented on code in PR #16605:
URL: https://github.com/apache/doris/pull/16605#discussion_r1103935888


##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -210,6 +210,10 @@ Status ColumnReader::read_page(const ColumnIteratorOptions& iter_opts, const Pag
     opts.type = iter_opts.type;
     opts.encoding_info = _encoding_info;
     opts.io_ctx = iter_opts.io_ctx;
+    // index page should not pre decode
+    if (iter_opts.type == INDEX_PAGE) {

Review Comment:
   it's a inner bug and logic here is two mistakes leads to running correnct, we already have case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org