[jira] [Updated] (MAPREDUCE-5660) Log info about possible thrashing (when using memory-based scheduling in Capacity Scheduler) is not printed

["Harsh J (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MAPREDUCE-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harsh J updated MAPREDUCE-5660:
-------------------------------
       Resolution: Fixed
    Fix Version/s: 1.3.0
         Assignee: Adam Kawa
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Thanks Adam, sorry on delay!

+1, Committed to branch-1 (patch needed a source path change, but applied clean).

> Log info about possible thrashing (when using memory-based scheduling in Capacity Scheduler) is not printed
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5660
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5660
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: capacity-sched, mrv1, tasktracker
>    Affects Versions: 1.2.1
>            Reporter: Adam Kawa
>            Assignee: Adam Kawa
>            Priority: Trivial
>             Fix For: 1.3.0
>
>         Attachments: MAPREDUCE-5660.1.patch.txt
>
>
> There is a tiny, but confusing when troubleshooting, bug in TaskTracker code:
> {code}
> if (totalMemoryAllottedForTasks > totalPhysicalMemoryOnTT) {
>   LOG.info("totalMemoryAllottedForTasks > totalPhysicalMemoryOnTT."
>       + " Thrashing might happen.");
> } else if (totalMemoryAllottedForTasks > totalVirtualMemoryOnTT) {
>   LOG.info("totalMemoryAllottedForTasks > totalVirtualMemoryOnTT."
>       + " Thrashing might happen.");
> }
> {code}
> totalMemoryAllottedForTasks is calculated in megabytes, while totalPhysicalMemoryOnTT (and totalVirtualMemoryOnTT) is calculated in bytes. totalMemoryAllottedForTasks should be converted to bytes for a correct comparison.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)