[jira] [Commented] (SOLR-6448) Improve SolrJ support for Collections API

["Varun Thacker (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-6448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136995#comment-14136995 ] 

Varun Thacker commented on SOLR-6448:
-------------------------------------

A few things that I noticed when looking at this - 

1. The async API call is only supported in the CREATE SolrJ call. It's supported in all of the collection APIs right? We should support it in all of it's equivalent SolrJ calls then
2. In SOLR-6073 we moved to a builder pattern. We should make the collection api calls immutable

For example this is what the API calls should look like
{code}
    new Create.CreateBuilder("testasynccollectioncreation")
        .numShards(1)
        .configName("conf1")
        .asyncId("1001")
        .build().process(server);
{code}
We can then have all the variables in the Create class be final.

> Improve SolrJ support for Collections API
> -----------------------------------------
>
>                 Key: SOLR-6448
>                 URL: https://issues.apache.org/jira/browse/SOLR-6448
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Anshum Gupta
>            Assignee: Anshum Gupta
>
> Right now SolrJ doesn't really support all of the collections API.
> This is a parent issue for bringing SolrJ support for all APIs up to where it should be.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org