[GitHub] [accumulo] dlmarion commented on pull request #3737: Use custom Transport Factory to set Transport message and frame size

["dlmarion (via GitHub)" <gi...@apache.org>]

dlmarion commented on PR #3737:
URL: https://github.com/apache/accumulo/pull/3737#issuecomment-1697948210

   Created as `draft` because I think a test needs to be added to confirm that the message and frame sizes are getting set. While looking at this I found several things:
   
   1. Not all Thrift server types use the framed transport
   
   2. According to [this](https://github.com/apache/thrift/blob/master/doc/specs/thrift-tconfiguration.md#maxframesize) all current implementations send one message in one frame, which begs the question why are we using framed transports.
   
   3. The Accumulo servers have properties for their max message size, which falls back to the general max message size when not defined. The remaining places where Thrift connections are created are using a maxMessageSize of `Integer.MAX_VALUE`. As mentioned, the Accumulo max message properties were not setting the Thrift `maxMessageSize`, they were setting the `maxFrameSize`. The default Thrift `maxMessageSize` is 100MB, so any frame size over that will get lowered to 100MB. This change sets the Thrift maxMessageSize, I'm unsure what will happen when the client and server have different values.
   
   4. Ideally, we should get reduce the max message size Accumulo properties to 1 and default it to a large value (2GB?).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org