[GitHub] [beam] iemejia commented on a change in pull request #10815: [BEAM-9279] Make HBase.ReadAll based on Reads instead of HBaseQuery

[GitBox <gi...@apache.org>]

iemejia commented on a change in pull request #10815: [BEAM-9279] Make HBase.ReadAll based on Reads instead of HBaseQuery
URL: https://github.com/apache/beam/pull/10815#discussion_r394846218
 
 

 ##########
 File path: sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java
 ##########
 @@ -173,33 +182,33 @@ public static Read read() {
     /** Reads from the HBase instance indicated by the* given configuration. */
     public Read withConfiguration(Configuration configuration) {
       checkArgument(configuration != null, "configuration can not be null");
-      return new Read(new SerializableConfiguration(configuration), tableId, serializableScan);
+      return new Read(new Configuration(configuration), tableId, scan);
     }
 
     /** Reads from the specified table. */
     public Read withTableId(String tableId) {
       checkArgument(tableId != null, "tableIdcan not be null");
-      return new Read(serializableConfiguration, tableId, serializableScan);
+      return new Read(configuration, tableId, scan);
     }
 
     /** Filters the rows read from HBase using the given* scan. */
     public Read withScan(Scan scan) {
       checkArgument(scan != null, "scancan not be null");
 
 Review comment:
   good one, fixing it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services