You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "aminghadersohi (via GitHub)" <gi...@apache.org> on 2026/04/20 21:39:35 UTC
[PR] chore(mcp): remove dead parse_request decorator and utility code [superset]
aminghadersohi opened a new pull request, #39497:
URL: https://github.com/apache/superset/pull/39497
## Summary
- Remove the obsolete `parse_request` decorator and 6 helper functions from `schema_utils.py`
- Remove `MCP_PARSE_REQUEST_ENABLED` config flag
- Remove ~510 lines of dead test code (`TestParseRequestDecorator`, `TestParseRequestFlattenedDecorator`)
- Update CLAUDE.md and auth.py comments
## Why
FastMCP 3.1+ handles Pydantic `BaseModel` parameters natively. PR #38918 (merged 2025-03-29) removed all usages from the 19 existing MCP tools. The decorator was left behind as dead code that causes degraded tool schemas (`anyOf [string, object]` instead of a clean object schema) if accidentally reused.
## Test plan
- [ ] Verify `parse_request` is no longer importable
- [ ] Existing MCP tools continue to work (they don't use this decorator)
- [ ] Remaining schema_utils tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(mcp): remove dead parse_request decorator and utility code [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi closed pull request #39497: chore(mcp): remove dead parse_request decorator and utility code
URL: https://github.com/apache/superset/pull/39497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(mcp): remove dead parse_request decorator and utility code [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39497:
URL: https://github.com/apache/superset/pull/39497#issuecomment-4284459796
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org