[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1392: feat: implement local IP address retrieval function

["PragmaTwice (via GitHub)" <gi...@apache.org>]

PragmaTwice commented on PR #1392:
URL: https://github.com/apache/incubator-kvrocks/pull/1392#issuecomment-1511603694

   Hi @zevin02, thanks for your contribution!
   
   We setup lots of code checks in our CI, which requires you to pass for better code quality.
   
   For example, from a glance to your code, maybe these checks will fail: 
   - local variables must be lower_case with underscore,
   - NULL must be replaced with nullptr
   
   You can check the CI log for more details and for how to modify your code to pass the CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org