You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/12/07 08:24:05 UTC

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1369: TINKERPOP-2472 Decouple the driver from the IO format

FlorianHockmann commented on pull request #1369:
URL: https://github.com/apache/tinkerpop/pull/1369#issuecomment-739757074


   > From how I understand this change, and assuming this PR builds on the recent move towards System.Text.Json, this change would allow me to easily stick to Newtonsoft.Json for the foreseeable future, wouldn't it?
   
   Yes, this targets `master` which is already on `System.Text.Json` which will be released with 3.5.0. And right, you can stick to `Newtonsoft.Json` with this change if you implement your own `IMessageSerializer`. You just have to implement especially the deserialization completely on your own as [the `GraphSONReader` still uses a type](https://github.com/apache/tinkerpop/blob/master/gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphSON/GraphSONReader.cs#L103) specific to our JSON library (`JsonElement`). We have this issue for quite some time ([TINKERPOP-1696](https://issues.apache.org/jira/browse/TINKERPOP-1696)) and I haven't found a way yet to get rid of this.
   But if you want to do the deserialization on your own, then this doesn't affect you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org